-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Améliorer la saisie avec un éditeur WYSIWYG #796
Open
yaaax
wants to merge
30
commits into
main
Choose a base branch
from
687-améliorer-la-saisie-erreurs-et-recommandations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "687-am\u00E9liorer-la-saisie-erreurs-et-recommandations"
+1,502
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
yaaax
changed the title
Add Tiptap and a first integration in NotesModal
Améliorer la saisoe des erreurs
Aug 9, 2024
yaaax
changed the title
Améliorer la saisoe des erreurs
Améliorer la saisie avec un éditeur WYSIWYG
Aug 9, 2024
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
August 16, 2024 17:48
d5003ef
to
2ba70c2
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
August 16, 2024 18:00
2ba70c2
to
31ce9e5
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
August 17, 2024 20:44
6672e96
to
b9a24e0
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
August 19, 2024 09:59
b9a24e0
to
1250bda
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
September 13, 2024 16:41
3251d48
to
9f3a245
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
October 24, 2024 16:02
75c5aeb
to
7981839
Compare
* Should handle existing markdown content * The editor is configured with extensions: * all what's in StarterKit * code block lowlight * highlight * link * task * typography (with french double quotes) * Some styles have been added to fit DSFR styling Still work in progress, but a nice start! To do: * image uploading and placement inside editor * menu buttons * accessibility tests and improvements
(and possibly importing JSON content?)
So you can see it in dark mode
Prop 'content' should define at least its type
Use uploadFileToStorage within saveExampleImage and saveNotesFile Fix dark background on notes thumbnails
(ATTACHMENT or EDITOR)
Add a new extension: ImageUploadTiptapExtension
Add a default value display=FileDisplay.ATTACHMENT in order to create a thumbnail by default
FETCH_ERROR is used, for the moment, when dragging and dropping an external image and a CORS issue happens
Handle multiple files, external URL, data URL
blue and bigger
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
November 15, 2024 16:44
9b59f25
to
d8b0c62
Compare
yaaax
force-pushed
the
687-améliorer-la-saisie-erreurs-et-recommandations
branch
from
November 27, 2024 09:58
d8b0c62
to
b43fd9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still work in progress, but a nice start!
To do: