Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard to warn user if no serial ports are found #81

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Brunius
Copy link

@Brunius Brunius commented Jun 14, 2023

This is a simple UX change to catch the low hanging fruit of "why doesn't this work? I hit the button and nothing happens!".

Before - Click the button, and this is what you see (no change)
image

After - Click the button, and an alert pops up!
image

So far, I have only tested this in Firefox and Edge. Edge will always offer you the option of COM1 on Windows, so it may be necessary to test this on another OS with a Chromium 89+ browser and no serial ports to confirm full coverage.

This impacts on some of the same areas as issue #42 - it's not a fix for operations in non-Chromium browsers, but it should at least let people know what's going on.

@github-actions github-actions bot added the EX-WebThrottle Item relates to EX-WebThrottle specifically label Jun 14, 2023
@Brunius
Copy link
Author

Brunius commented Jun 14, 2023

  • Could / should this be a more fleshed out error message?
    Yeah, possibly. At this point I wanted something simple and easy - I'm no JS expert, so I just went for the easiest way of doing so.

  • We're pointing them to the documentation - should we include a link, or specific section in the documentation?
    Yeah, maybe. I didn't want to play with the documentation too much as I don't know if I'd be treading on any toes (or, where I could play with it). The other aspect to that, is how do we explain to someone who may not know browsers why they need to use a different browser? Or is it enough to simply say "use Edge or Chrome instead of Firefox"?

@Brunius
Copy link
Author

Brunius commented Jun 14, 2023

Tested on Firefox 114.0.1 (64-bit) and Edge 114.0.1823.43 (64-bit) on Windows 10, with no issues as far as I could see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EX-WebThrottle Item relates to EX-WebThrottle specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant