fix: change Component.Evidence.Identity to array
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DmitriyLewen <[email protected]>
Signed-off-by: DmitriyLewen <[email protected]>
Signed-off-by: DmitriyLewen <[email protected]>
Signed-off-by: DmitriyLewen <[email protected]>
DmitriyLewen
force-pushed
the
fix/componentEvidence-as-array
branch
from
9331e90
to
76dd76b
Compare
Signed-off-by: DmitriyLewen <[email protected]>
Signed-off-by: DmitriyLewen <[email protected]>
Signed-off-by: DmitriyLewen <[email protected]>
DmitriyLewen
commented
Oct 28, 2024
Comment on lines
+198
to
+204
| // Spec version 1.5 uses only one Identity. | ||
| // cf. https://cyclonedx.org/docs/1.5/json/#components_items_evidence_identity | ||
| if c.Evidence.Identity != nil { | ||
| ids := *c.Evidence.Identity | ||
| ids = ids[:1] | ||
| c.Evidence.Identity = &ids | ||
| } |
There was a problem hiding this comment.
I'm not sure about this way...
Maybe we need to select one Identifier using Field with some order
Please tell me if you have a better solution.
There was a problem hiding this comment.
I overwrite all the Evidence fields in the MarshalXML and UnmarshalXML functions, so I added test cases for each field.
Tell me if this is too much
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in CycloneDX 1.6 type of
Component.Evidence.Identityhas been changed to[]Identity.Identityasstructwas marked asdeprecated.https://cyclonedx.org/docs/1.6/json/#tab-pane_metadata_component_evidence_identity_oneOf_i0
Related issues
Component.Evidence.Identityfield in CycloneDX 1.6 #192