Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

651 conda activate fix mk #682

Closed
wants to merge 178 commits into from
Closed

Conversation

martinkilbinger
Copy link
Contributor

Summary

Developers should provide a summary of the proposed changes here and include "closes #" if this addresses an open issue.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

sfarrens and others added 30 commits November 16, 2022 09:36
Conflicts:
	Dockerfile
	environment.yml
	scripts/sh/init_canfar.sh
martinkilbinger and others added 25 commits March 6, 2024 13:26
@martinkilbinger martinkilbinger self-assigned this Oct 21, 2024
@sfarrens
Copy link
Member

@martinkilbinger you should keep an eye on #665, I have working CI and updated the whole build system.

@martinkilbinger martinkilbinger deleted the 651-conda-activate-fix-MK branch October 21, 2024 14:14
@martinkilbinger
Copy link
Contributor Author

@martinkilbinger you should keep an eye on #665, I have working CI and updated the whole build system.

I'm cleaning up, merging to my fork and deleting a few old branches. That will hopefully make it easier to merge my current branch (running SP v1.4) to upstream later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants