Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[housekeeping] Automated PR to fix formatting errors #1563

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated PR to fix formatting errors

@github-actions github-actions bot added the approved This Proposal has been approved and is ready to be added to the Toolkit label Nov 24, 2023
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from 2fded80 to 8c9d966 Compare November 24, 2023 00:08
@brminnick brminnick added the do not merge Do not merge this PR label Nov 24, 2023
@brminnick brminnick removed the approved This Proposal has been approved and is ready to be added to the Toolkit label Nov 24, 2023
@github-actions github-actions bot added the approved This Proposal has been approved and is ready to be added to the Toolkit label Nov 25, 2023
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from 8c9d966 to 9177ee6 Compare November 27, 2023 00:09
@jfversluis
Copy link
Member

Aggressive bot being aggressive 😄 I guess we want to hold of merging because of those obsolete attributes?

@brminnick
Copy link
Collaborator

I guess we want to hold of merging because of those obsolete attributes?

Agreed.

It's because dotnet format now adds [Obsolete] attributes when it detects usage of an obsolete API.

We won't be able to get rid of this noise until we upgrade MediaElement away from ExoPlayer, but we're blocked on that: #1511

@bijington
Copy link
Contributor

Would it be a bad thing to suppress those warnings just for that part of the namespace until we solve it?

@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch 2 times, most recently from 952ff73 to a1dbd31 Compare November 30, 2023 00:10
@brminnick brminnick marked this pull request as draft November 30, 2023 18:25
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from a1dbd31 to bd3f453 Compare December 1, 2023 00:05
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from bd3f453 to 0d3145b Compare December 8, 2023 00:07
@brminnick brminnick removed the approved This Proposal has been approved and is ready to be added to the Toolkit label Dec 8, 2023
@github-actions github-actions bot added the approved This Proposal has been approved and is ready to be added to the Toolkit label Dec 9, 2023
@brminnick brminnick added blocked and removed approved This Proposal has been approved and is ready to be added to the Toolkit labels Dec 11, 2023
@github-actions github-actions bot added the approved This Proposal has been approved and is ready to be added to the Toolkit label Dec 12, 2023
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from 0d3145b to 14af845 Compare January 15, 2024 00:08
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch 2 times, most recently from 3a41b60 to 1d63d57 Compare February 3, 2024 00:08
@github-actions github-actions bot force-pushed the housekeeping/fix-codeformatting branch from 1d63d57 to 8eff768 Compare February 15, 2024 00:06
@brminnick brminnick marked this pull request as ready for review February 15, 2024 21:31
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet format no longer adds [ObsoleteAttribute]

@brminnick brminnick merged commit 97440cc into main Feb 15, 2024
2 of 7 checks passed
@brminnick brminnick deleted the housekeeping/fix-codeformatting branch February 15, 2024 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved This Proposal has been approved and is ready to be added to the Toolkit blocked do not merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants