Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to shakapacker #2236

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Migrate to shakapacker #2236

wants to merge 13 commits into from

Conversation

jhmegorei
Copy link
Collaborator

No description provided.

@jhmegorei jhmegorei marked this pull request as ready for review November 19, 2024 15:02
jhmegorei and others added 12 commits November 19, 2024 16:03
Steps to reproduce:
docker-compose -f docker-compose.dev.yml run app bash
bundle install
asdf reshim # no idea why but didn't work without it
./bin/rails shakapacker:install

Removed duplicate entries from .gitignore
- migrate all references to app/packs to app/javascript
- migrate all references to webpacker to shakapacker (notable exclusion: docker-compose.dev.yml so users don't have to rebuild the whole container)
- remove all references to app/packs/klasses.json and config/klasses.json. Those are no longer existing. The only place where a klasses.json is residing is public/klasses.json, as written by the Labimotion gem
Copy link

LCOV of commit ba4e5b2 during Continuous Integration #4163

Summary coverage rate:
  lines......: 65.5% (14037 of 21436 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants