-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to shakapacker #2236
Open
jhmegorei
wants to merge
13
commits into
main
Choose a base branch
from
migrate-to-shakapacker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate to shakapacker #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiTrem
reviewed
Nov 12, 2024
Steps to reproduce: docker-compose -f docker-compose.dev.yml run app bash bundle install asdf reshim # no idea why but didn't work without it ./bin/rails shakapacker:install Removed duplicate entries from .gitignore
- migrate all references to app/packs to app/javascript - migrate all references to webpacker to shakapacker (notable exclusion: docker-compose.dev.yml so users don't have to rebuild the whole container) - remove all references to app/packs/klasses.json and config/klasses.json. Those are no longer existing. The only place where a klasses.json is residing is public/klasses.json, as written by the Labimotion gem
jhmegorei
force-pushed
the
migrate-to-shakapacker
branch
from
November 19, 2024 15:03
8c422f7
to
ef83539
Compare
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.