Fix some minor js issues #2184
Draft
Fix some minor js issues #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiwald
reviewed
Sep 26, 2024
| updatedLiterature.refs = { citation, bibtex: citation.format('bibtex'), bibliography: json.format('bibliography') }; | ||
|
|
||
| return ({ literature: updatedLiterature }); | ||
| }); |
There was a problem hiding this comment.
I think this modifies the prevState.literature object. This may not cause any issues but I'd prefer creating a new object, as in {…prevState.literature, doi: doi, etc… }
| updatedLiterature.refs = { citation, bibtex: citation.format('bibtex'), bibliography: json.format('bibliography') }; | ||
|
|
||
| return ({ literature: updatedLiterature }); | ||
| }); | ||
| const { literature } = this.state; | ||
| this.handleLiteratureAdd(literature); |
There was a problem hiding this comment.
Just looking at this, it seems odd that we are calling handleLiteratureAdd with the current literature object, that has not been affected by the changes in setState above.
The value is internally converted to a numeral anyway, so we can be lenient in accepting data. Additionally, the component was called with a no longer existing property, which I removed as well.
…e object, not a JS Object This caused Proptype Errors in AddButton and Citation
…onent The original issue was just that the ToggleButton was situated in the Tab Button, which throws an error, because you are not allowed to nest a <button> within a <button>. Then it occurred to me, that this was the only instance where this button is used and that it's usage (namely toggling reaction scheme between default and gaseous) was not very clear until you hover over the button and read the tooltip. Therefore I replaced it by a regular bootstrap buttongroup we also use in other places. This way, the toggling functionality becomes clear directly, as both buttons are displayed at the same time. So no more hover necessary. Additionally, the buttons use a global utility component for easier styling of toggle buttons throughout the app.
The render function sets a default, so the prop is definitely not required
…hment for PropType checking
…string-like contexts anyway
jhmegorei
force-pushed
the
fix-some-minor-js-issues
branch
from
07ac02e
to
0866fd8
Compare
LCOV of commit
|
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I clicked through the app and noted a lot of small JS errors in development mode (mostly PropType related).
This PR fixes them as good as possible.