Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conversion rate in reaction scheme #2159

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: conversion rate in reaction scheme #2159

wants to merge 4 commits into from

Conversation

adambasha0
Copy link
Contributor

@adambasha0 adambasha0 commented Sep 17, 2024 •
edited
Loading

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@adambasha0 adambasha0 self-assigned this Sep 17, 2024
@github-actions GitHub Actions
Copy link

LCOV of commit 49e7400 during Continuous Integration #3803

Summary coverage rate:
  lines......: 65.5% (14025 of 21426 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions[bot]
github-actions bot reviewed Sep 18, 2024
View reviewed changes
app/api/helpers/report_helpers.rb
@@ -614,6 +614,7 @@ def build_sql_reaction_sample(columns, c_id, ids, checkedAll = false)
# reactions_sample:
equivalent: ['r_s.equivalent', '"r eq"', 10],
reference: ['r_s.reference', '"r ref"', 10],
conversion_rate: ['r_s.conversion_rate', '"r conversion rate"', 10],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/ModuleLength: Module has too many lines. [611/100]

app/usecases/reactions/update_materials.rb
@@ -113,7 +113,7 @@ def create_new_sample(sample, fixed_label)
:type, :molecule, :collection_id, :short_label, :waste, :show_label, :coefficient, :user_labels,
:boiling_point_lowerbound, :boiling_point_upperbound,
:melting_point_lowerbound, :melting_point_upperbound, :segments, :gas_type,
:gas_phase_data
:gas_phase_data, :conversion_rate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/AbcSize: Assignment Branch Condition size for create_new_sample is too high. [<9, 35, 5> 36.48/25]

app/usecases/reactions/update_materials.rb
@@ -215,6 +215,7 @@ def associate_sample_with_reaction(sample, modified_sample, material_group)
type: reactions_sample_klass,
gas_type: sample.gas_type,
gas_phase_data: sample.gas_phase_data,
conversion_rate: sample.conversion_rate,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/AbcSize: Assignment Branch Condition size for associate_sample_with_reaction is too high. [<2, 26, 2> 26.15/25]

app/usecases/reactions/update_materials.rb
@@ -215,6 +215,7 @@ def associate_sample_with_reaction(sample, modified_sample, material_group)
type: reactions_sample_klass,
gas_type: sample.gas_type,
gas_phase_data: sample.gas_phase_data,
conversion_rate: sample.conversion_rate,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/MethodLength: Method has too many lines. [32/30]

lib/import/import_json.rb
@@ -82,6 +82,9 @@ class Import::ImportJson
# 'r_uuid' => nil,
# 'r_reference' => nil,
# 'r_equivalent' => nil,
# 'r_gas_type' => nil,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/ClassLength: Class has too many lines. [285/200]

lib/import/import_json.rb
@@ -374,7 +377,9 @@ def add_to_reaction(klass, el, new_el)
if new_data && new_data[r_uuid] && new_data[r_uuid]['id']
@log['samples'][el_uuid][klass.name] = klass.create(
sample_id: new_el.id, reaction_id: new_data[r_uuid]['id'],
reference: ref, equivalent: eq, position: el['r_position']
reference: ref, equivalent: eq, position: el['r_position'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.

lib/reporter/docx/detail_reaction.rb
@@ -361,7 +361,7 @@ def material_hash(material, is_product=false)
mol: valid_digit(mmol, digit),
mmol_unit: mmol_unit,
equiv: valid_digit(s.equivalent, digit),
molecule_name_hash: s[:molecule_name_hash]
molecule_name_hash: s[:molecule_name_hash],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/ClassLength: Class has too many lines. [627/200]

lib/reporter/docx/detail_reaction.rb
@@ -361,7 +361,7 @@ def material_hash(material, is_product=false)
mol: valid_digit(mmol, digit),
mmol_unit: mmol_unit,
equiv: valid_digit(s.equivalent, digit),
molecule_name_hash: s[:molecule_name_hash]
molecule_name_hash: s[:molecule_name_hash],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/AbcSize: Assignment Branch Condition size for material_hash is too high. [<10, 51, 7> 52.44/25]

lib/reporter/docx/detail_reaction.rb
@@ -361,7 +361,7 @@ def material_hash(material, is_product=false)
mol: valid_digit(mmol, digit),
mmol_unit: mmol_unit,
equiv: valid_digit(s.equivalent, digit),
molecule_name_hash: s[:molecule_name_hash]
molecule_name_hash: s[:molecule_name_hash],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/CyclomaticComplexity: Cyclomatic complexity for material_hash is too high. [8/7]

lib/reporter/docx/detail_reaction.rb
@@ -361,7 +361,7 @@ def material_hash(material, is_product=false)
mol: valid_digit(mmol, digit),
mmol_unit: mmol_unit,
equiv: valid_digit(s.equivalent, digit),
molecule_name_hash: s[:molecule_name_hash]
molecule_name_hash: s[:molecule_name_hash],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/MethodLength: Method has too many lines. [32/30]

@github-actions GitHub Actions
Copy link

LCOV of commit 76bd417 during Continuous Integration #3808

Summary coverage rate:
  lines......: 65.5% (14027 of 21428 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit e6b2e54 during Continuous Integration #3829

Summary coverage rate:
  lines......: 65.5% (14026 of 21429 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@adambasha0
Copy link
Contributor Author

Chemotion.dev.8.webm

@adambasha0
Copy link
Contributor Author

Chemotion.dev.9.webm

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

LCOV of commit 729eeeb during Continuous Integration #3959

Summary coverage rate:
  lines......: 65.5% (14024 of 21424 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 3f82f54 during Continuous Integration #3995

Summary coverage rate:
  lines......: 65.5% (14024 of 21424 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

LCOV of commit a11b53b during Continuous Integration #4117

Summary coverage rate:
  lines......: 65.5% (14011 of 21403 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem changed the title conversion rate in reaction scheme feat: conversion rate in reaction scheme Nov 7, 2024
ashwiniHerle
ashwiniHerle reviewed Nov 12, 2024
View reviewed changes
app/packs/src/components/common/ToggleButton.js Outdated
@@ -24,9 +28,9 @@ export default function ToggleButton({
className={`toggle-button ${isToggled ? 'on' : 'off'}`}
size="xs"
onClick={handleChange}
style={{ backgroundColor: buttonColor, minWidth: '50px', border: 'none' }}
style={{ backgroundColor: buttonColor, border: 'none', padding: '0px 0px 0px 0px' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inline style can be replaced with corresponding bootstrap utility classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ashwiniHerle ashwiniHerle ashwiniHerle left review comments

@TasnimMehzabin TasnimMehzabin TasnimMehzabin approved these changes

Assignees

@adambasha0 adambasha0

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adambasha0 @TasnimMehzabin @ashwiniHerle