Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/versioning enhanced #1253

Closed
wants to merge 5 commits into from
Closed

Commits on Mar 29, 2023

  1. Configuration menu
    Copy the full SHA
    f5f91ec View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Refactor ReactionDetails and SampleDetails

    This commit refactors `ReactionDetails` and `SampleDetails` to make them pass eslint checks.
    
    We had  unused functions there, which will be removed by this commit:
    
    - SampleDetails#initiateAnalysisButton
    
    - SampleDetails#initiateAnalysisWithKind
    
    - SampleDetails#transferToDeviceButton
    
    Also disables `forbid-prop-types` in .eslintrc for now. This can be taken out later, when we can better specify the propTypes across the entire project.
    mschneider85 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    38114e2 View commit details
    Browse the repository at this point in the history
  2. Add a change history /w logidze

    Store a history which keeps track of every change made to certain
    entities and add a "History" tab to the Reaction/Sample detail pages.
    Related entities are displayed in the version history. E.g. Reaction ->
    ReactionsSample
    
    Save timestamp and author of the version with the changes. A change diff
    to the previous version can be displayed.
    
    Tracked entities:
    
    - Attachment
    
    - Container
    
    - ElementalComposition
    
    - Reaction
    
    - ReactionsSample
    
    - Residue
    
    - Sample
    
    Co-authored-by: VadimKeller <[email protected]>
    mschneider85 and VadimKeller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    c63f1de View commit details
    Browse the repository at this point in the history
  3. Add svg formatter and json

    Add revert button to versioned field
    
    reset colum information
    
    re-create schema
    
    update solvent label
    Danny Truong authored and mschneider85 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    971ce24 View commit details
    Browse the repository at this point in the history
  4. Enhance versioning + revert function

    Make revert function work (#780)
    
    - Update version list after reverting a change
    
    - Fix issue /w big svgs
    
    - Make reverting molfile / svg work
    
    - Fix merge issues
    
    - Replace passing local variables /w using state
    
    Add missing versioning for Screens, Wellplates, and Research plans
    
    Change the way versions are displayed in the version table. Previously
    we had one version per database update. Now we group versions by the
    request id. These changes are now merged to make it more intuitive for
    the user.
    
    Implement revert functionality /w fetchers, reverters, and serializers
    
    Implement a new revert UI with one button per version and one modal to
    select revertible values. Delete old revert button.
    
    Co-authored-by: Martin Schneider <[email protected]>
    Co-authored-by: VadimKeller <[email protected]>
    3 people committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    be07bbb View commit details
    Browse the repository at this point in the history