Remove react-clipboard.js and replace by using react-copy-to-clipboard package #979
+51
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talyssonoc
requested changes
Oct 3, 2024
app/assets/javascripts/components/story/ExpandedStory/ExpandedStoryHistoryLocation.jsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/components/story/StoryCopyIdClipboard.jsx
Outdated
Show resolved
Hide resolved
wrspada02
force-pushed
the
fix/issue-923-updated
branch
from
a7bfa7b
to
e2d7afe
Compare
wrspada02
force-pushed
the
fix/issue-923-updated
branch
from
3221261
to
4124fea
Compare
talyssonoc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do ?
Remove react-clipboard.js and replace by using react-copy-to-clipboard package
Related Issues
#923
Screenshots (if applicable)
Additional Notes (if any)
Besides the above prints I tested it manually, looks good. The functionality works well and the html, css are good.