Inherit Symfony pre-built assertions #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TavoNiievez
force-pushed
the
symfony-asserts
branch
6 times, most recently
from
1987a3d
to
6a99658
Compare
TavoNiievez
force-pushed
the
symfony-asserts
branch
4 times, most recently
from
110c0cd
to
6cc7f88
Compare
TavoNiievez
changed the title
TavoNiievez
force-pushed
the
symfony-asserts
branch
from
6cc7f88
to
b6d9690
Compare
TavoNiievez
changed the title
TavoNiievez
force-pushed
the
symfony-asserts
branch
from
b6d9690
to
9d3f6f7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony already includes a large list of assertions.
module-symfonyusers should not have to give them up when deciding to use Codeception.So this PR is an attempt to add to Codeception's
$I->syntax the assertions that are already built into Symfony, making the module a functional testing superset for Symfony rather than a replacement or competitor.The obvious benefit of doing this is that people who already have tests in Symfony will find it easier to migrate to Codeception as it will not be necessary to spend time finding and rewriting tests in the Codeception equivalent of that assertion (where there is one).