Jameswgoddard/issue 345 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue-345 by removing unpredicatable parameters from the /contact/send section of swagger.json. Ensured app is not trying to listen on the same port twice so that npm test will pass. Shamelessly added myself to the contributors file :-)
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 83.91% 82.87% -1.05%
==========================================
Files 17 17
Lines 684 695 +11
==========================================
+ Hits 574 576 +2
- Misses 110 119 +9
Continue to review full report at Codecov.
|
Updated password for new user test to pass pwaard criteria
|
@jameswgoddard I'm in the process of reviewing and testing this PR. I've updated the postman collection so that the POST User passes as expected. |
blakenan-bellese
requested changes
Feb 2, 2021
blakenan-bellese
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should close issue-343 , issue-344, and issue-345
Related PRs
List related PRs against other branches:
Deploy Notes
docker-compose up -d --buildSteps to Test or Reproduce
Manual testing using swaggerUI as appropriate based on the issues linked above.
Impacted Areas in Application
List general components of the application that this PR will affect: