Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiecho #389

Draft
wants to merge 11 commits into
base: multi-echo
Choose a base branch
from
Draft

multiecho #389

wants to merge 11 commits into from

Conversation

davidgruskin
Copy link
Contributor

No description provided.

@gdevenyi
Copy link
Member

Thanks @davidgruskin, first order of business is to rebase your changes so that they're not conflicting with the current state of the repo. I imagine you did you changes against an earlier version of master 👍

@davidgruskin davidgruskin changed the title Multiecho multiecho Oct 17, 2024
@davidgruskin
Copy link
Contributor Author

Thanks @gdevenyi! I just rebased my changes but am not 100% confident I didn't introduce bugs in the process- also, I imagine some of the decisions I made a year ago with respect to pre-multiecho processing (e.g., file selection and parsing) are suboptimal. @Gab-D-G, did you still want to create the iterables/joinnodes and have me take care of the multi-echo specific processing, or would you prefer that I take a stab at all that stuff first before roping you in?

@Gab-D-G
Copy link
Collaborator

Gab-D-G commented Oct 23, 2024

Hi @davidgruskin, great to hear from you, and no worries regarding the delays. Unfortunately, I myself can't step into coding at the moment, as I have deadlines to meet for the next couple months. I expect to have more time somewhere in the winter/spring. So if you want to start now, you can go ahead and give it a try. I can still help with specific questions, but can't commit to heavy coding myself.

In case you haven't come across this, there's some recommendations to help RABIES dev https://rabies.readthedocs.io/en/latest/contributing.html, although it doesn't deal with the issue of iterables. In the upcoming TOPUP implementation, we had also to deal with the issue of setting iterables for handling the two opposite PE directions, so you may find it helpful to consult the current PR master...amrka:RABIES:PhaseEncoding, although it isn't finalized.

@davidgruskin
Copy link
Contributor Author

@Gab-D-G Sounds great, thanks for the heads-up- I'll take a look at the TOPUP PR and get started on this soon, hopefully in the next week or so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants