Build native binaries by GitHub Actions #3
Merged
+232
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizumi
reviewed
Sep 4, 2023
| cd build | ||
| cmake .. -G "Xcode" -DCMAKE_BUILD_TYPE=Release \ | ||
| -DBUILD_SHARED_LIBS=OFF -DOPUS_BUILD_PROGRAMS=OFF \ | ||
| -DMACOSX_DEPLOYMENT_TARGET=10.13 -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" |
rizumi
reviewed
Sep 4, 2023
.github/workflows/build.yml
Outdated
| -DBUILD_SHARED_LIBS=OFF -DOPUS_BUILD_PROGRAMS=OFF \ | ||
| -DAVX_SUPPORTED=OFF | ||
| cmake --build . --config Release | ||
| cp Release/opus.lib ../../Plugin/libopus/lib/Release/opus.lib |
There was a problem hiding this comment.
../../Plugin/libopus/lib/Release/opus.lib
絶対パスの方が可読性と後からディレクトリ構成変えたりした場合のメンテ楽になりそうですが、 $GITHUB_WORKSPACE とかは working-directory を指定した場合そっちが返るんでしたっけ？
There was a problem hiding this comment.
確かに $GITHUB_WORKSPACE のほうが可読性良さそうなのでそうしたいと思います 👍 (working-directory には依存しないと思います)
rizumi
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnityOpus のネイティブバイナリ (libopus+α) を GitHub Actions でビルドできるようにします。
使い方
gha/ベースブランチ) にビルド済みのバイナリをコミットして push します既存バイナリからの変更点