Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: service: add pre-start configuration validator #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 26, 2019

  1. Feature: service: add pre-start configuration validator

    1) Currently the only hard errors are:
    
    - sbd binary is not existing or not executable.
    
    - 'TimeoutStartSec' of service is shorter than 'msgwait' if
    'SBD_DELAY_START' is enabled.
    
    - 'TimeoutStartSec' of service is shorter than the delay value
    explicitly configured with 'SBD_DELAY_START'.
    
    Hard errors prevent service from starting.
    
    2) Warnings are given if:
    
    - sbd devices are not existing.
    
    - meta-data cannot be read from sbd devices.
    
    On start-up, since sbd daemon waits for sbd devices to appear and get
    ready within start-up timeout, such situations shouldn't prevent service
    from starting. Besides, for the latter situation, it doesn't necessarily
    mean sbd devices are not correctly initialized. But anyway warnings are
    given.
    
    3) Notices are given if:
    
    - '/etc/sysconfig/sbd' is not existing.
    
    - 'SBD_DEVICE' is not configured in case it's unintentional.
    
    - 'TimeoutStartUSec'/'TimeoutStartSec' setting of service somehow cannot
    be retrieved or recognized.
    
    - 'TimeoutStartSec' of service is shorter than sbd start-up timeout.
    
    - 'SBD_DELAY_START' is enabled but not by being specified an explicit
    delay value (It's recommended to set it to be longer than 'corosync
    token timeout + consensus timeout + pcmk_delay_max/base + msgwait').
    
    - 'SBD_DELAY_START' is configured with an explicit delay value but
    shorter than the configured 'msgwait'
    
    These are not strictly or necessarily mis-configuration. They shouldn't
    prevent service from starting either.
    gao-yan committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    79835b5 View commit details
    Browse the repository at this point in the history