build: configure: have --with-runstatedir overrule --runstatedir #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaillot
reviewed
Dec 9, 2021
| echo "over runstatedir=${runstatedir}." | ||
| echo "Consider using --runstatedir=${sbd_runstatedir} directly or let it" | ||
| echo "go with the default." | ||
| runstatedir="${sbd_runstatedir}"]) |
There was a problem hiding this comment.
I believe this will only do anything if runstatedir is empty
I think we want something like
AS_IF([test x"${sbd_runstatedir}" != x""],
[
AS_IF([test x"${runstatedir}" != x""], [echo "...taking precedence..."])
runstatedir="${sbd_runstatedir}"
])
There was a problem hiding this comment.
Well it did work in my tests.
According to documentation AS_IF is more like if ... then ... else if ... then ... else ...
There was a problem hiding this comment.
Oh right, I misread the third block as else rather than else if
looks good to me
and log that there was runstatedir defined already
wenningerk
force-pushed
the
overrule_runstatedir
branch
from
ff38c41
to
d9af069
Compare
|
What do you think? Disables your logic I know ... |
|
test this please |
Looks good. Thanks! |
|
Then let's go with this till 2.70 has landed safely and we see how that behaves with the distros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and log that there was runstatedir defined already
This is continuation of discussion at #136