Remove global variable from notify_client #154
+394
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also requires modifying foreach_tkt_req to take a config variable as well. Co-authored-by: Jan Pokorny <[email protected]>
Co-authored-by: Jan Pokorny <[email protected]>
* Add braces around some nearby conditional blocks. * Make add_hmac a static function and move it up in the source file to avoid a function declaration. * Convert _FOREACH_NODE to FOREACH_NODE in booth_udp_broadcast_auth. * Change other network functions to be static. Co-authored-by: Jan Pokorny <[email protected]>
jfriesse
approved these changes
Nov 20, 2024
| struct booth_site *leader, | ||
| struct boothc_ticket_msg *msg | ||
| ) | ||
| static int process_UPDATE (struct booth_config *conf, struct ticket_config *tk, |
There was a problem hiding this comment.
I think it make sense to remove space between process_UPDATE and { similarly as elsewhere (answer_HEARTBEAT, process_REVOKE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one got a little out of control, unfortunately, due to all the networking related functions that call each other. However, there's nothing tricky going on here. It's just adding a parameter all over the place.