Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set animations to empty list if null in SerializedSkin.Builder #265

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from

Conversation

irrld
Copy link

@irrld irrld commented Oct 27, 2024

When builder.animations(...) is not called, it causes builder.build() to fail with the following stack trace. This PR fixes the issue by initializing the animations to empty list just like what's being done with personaPieces and tintColors

Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Collection.size()" because "c" is null
	at it.unimi.dsi.fastutil.objects.ObjectArrayList.<init>(ObjectArrayList.java:135) ~[lux.jar:?]
	at org.cloudburstmc.protocol.bedrock.data.skin.SerializedSkin.of(SerializedSkin.java:101) ~[lux.jar:?]
	at org.cloudburstmc.protocol.bedrock.data.skin.SerializedSkin$Builder.build(SerializedSkin.java:322) ~[lux.jar:?]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant