Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-2302] Update HTML template for inapp preview. #383

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

nishant-clevertap
Copy link
Contributor

  • Updated HTML template for inapp preview.
  • Added check for inapp advanced builder type also.

- Added check for inapp advanced builder type also.
@nzagorchev
Copy link
Contributor

@nishant-clevertap I see some differences when comparing the HTML with the one on Android, can you please check? CleverTap/clevertap-android-sdk#680

@vasct
Copy link

vasct commented Nov 14, 2024

@nishant-clevertap I see some differences when comparing the HTML with the one on Android, can you please check? CleverTap/clevertap-android-sdk#680

Here is the one used for Android from Svetoslav's PR: Link

- Updated wrap ImageInterstitial content to replace without quotes.
Copy link
Collaborator

@akashvercetti akashvercetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@akashvercetti akashvercetti merged commit 2626df0 into develop Nov 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants