Be more precise on how to get a LE certificate #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment has finished 👁️👄👁️ Your app is available here |
|
🚀 You updated your review app. Check it here |
|
🚀 You updated your review app. Check it here |
davlgd
reviewed
Nov 8, 2024
judu
force-pushed
the
judu/improve-letsencrypt-doc
branch
from
ba640f4
to
36b9cd3
Compare
…verCloud/documentation into judu/improve-letsencrypt-doc
|
🚀 You updated your review app. Check it here |
|
🚀 You updated your review app. Check it here |
|
🚀 You updated your review app. Check it here |
cnivolle
requested changes
Nov 8, 2024
|
There are two warnings left. I added Let’s Encrypt and DNS to allowed phrases, but Vale still warns about them 🤔 |
Co-authored-by: Clément Nivolle <[email protected]>
|
🚀 You updated your review app. Check it here |
|
🚀 You updated your review app. Check it here |
cnivolle
approved these changes
Nov 19, 2024
|
@judu can you resolve the latests conflicts please? |
Juju-archy
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User often add domains to their applications, only to have the DNS records configured weeks or month later. At that point, the certificate manager stopped trying to generate a certificate.
Changelog:
Checklist