Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: automate external doc updates #388

Merged
merged 17 commits into from
Nov 29, 2024
Merged

Feat: automate external doc updates #388

merged 17 commits into from
Nov 29, 2024

Conversation

juliamrch
Copy link
Collaborator

@juliamrch juliamrch commented Oct 2, 2024

Describe your PR

A Clever Cloud guide has been included on Astro, and therefore we updated as well our guide to include detailed configuration depending on whether it's deployed on a static or a node application.

In order to avoid asynchronicity between our development and the external doc posted on diverse frameworks, I wrote an automation to check if the modified files are linked to some external doc. If relevant, the bot creates an issue and assign it to the PR author, as well as notifying this on a comment.

Checklist

Reviewers

Who should review these changes? @cnivolle

@juliamrch juliamrch added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 2, 2024
@juliamrch juliamrch self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Deployment has finished 👁️👄👁️ Your app is available here

Copy link

github-actions bot commented Oct 3, 2024

🚀 You updated your review app. Check it here

Copy link

github-actions bot commented Oct 4, 2024

🚀 You updated your review app. Check it here

Copy link

github-actions bot commented Oct 7, 2024

🚀 You updated your review app. Check it here

Copy link
Collaborator

@davlgd davlgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I didn't review the action part, only the guide.

.gitignore Show resolved Hide resolved
content/guides/astro.md Outdated Show resolved Hide resolved
content/guides/astro.md Outdated Show resolved Hide resolved
content/guides/astro.md Outdated Show resolved Hide resolved
content/guides/astro.md Show resolved Hide resolved
Copy link

🚀 You updated your review app. Check it here

Copy link

🚀 You updated your review app. Check it here

@juliamrch juliamrch added the waiting Waiting from fixes or tests by submitter label Oct 21, 2024
Copy link

🚀 You updated your review app. Check it here

Copy link

🚀 You updated your review app. Check it here

Copy link

🚀 You updated your review app. Check it here

davlgd
davlgd previously requested changes Oct 31, 2024
content/guides/astro.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 4, 2024

🚀 You updated your review app. Check it here

@juliamrch juliamrch requested a review from davlgd November 4, 2024 14:44
Copy link

🚀 You updated your review app. Check it here

Copy link

🚀 You updated your review app. Check it here

Copy link

🚀 You updated your review app. Check it here

@cnivolle cnivolle dismissed davlgd’s stale review November 29, 2024 15:59

Review taken into account, but outdated check from GitHub.

@cnivolle cnivolle merged commit 82bc402 into main Nov 29, 2024
3 checks passed
@cnivolle cnivolle deleted the astro-guide branch November 29, 2024 15:59
Copy link

You closed this PR and deleted the review app 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Doc: Astro Guide improvement
5 participants