Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) #1294

Merged
merged 3 commits into from
Nov 20, 2024
Merged

[minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) #1294

merged 3 commits into from
Nov 20, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Nov 4, 2024 •
edited
Loading

A new bitmask property exists in the latest version of ACI meta-data for pkiTP called certUsage.

When the meta-data is updated currently the generator fails with:

panic: template: :12:172: executing "" at <$.Definitions>: range can't iterate over WebSvcOrAuth

goroutine 1 [running]:
main.renderTemplate({0x1276803, 0x12}, {0xc000c60310, 0xa}, {0x12736bd, 0xe}, {0x126d5c0?, 0xc0014f7400?})
        C:/git/Terraform Project/terraform-provider-aci/gen/generator.go:569 +0xa55
main.main()
        C:/git/Terraform Project/terraform-provider-aci/gen/generator.go:934 +0xb70
exit status 2
main.go:20: running "go": exit status 1

DOD:

  • Fix generator to handle this new property use case
  • Update pkiTP metadata and generate new code
  • Out of Scope: Functioning integration tests until an updated APIC is available.

@samiib samiib self-assigned this Nov 4, 2024
@samiib samiib changed the title [minor_change] Added certificate_usage property to aci_certificate_authority [minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (24898fb) to head (7b1caf3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nal/provider/resource_aci_certificate_authority.go 58.62% 10 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   83.74%   83.76%   +0.02%     
==========================================
  Files         123      123              
  Lines       56180    56214      +34     
==========================================
+ Hits        47049    47090      +41     
  Misses       7255     7255              
+ Partials     1876     1869       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@samiib samiib marked this pull request as ready for review November 6, 2024 09:09
anvitha-jain
anvitha-jain previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Nov 8, 2024
View reviewed changes
gen/definitions/properties.yaml Outdated Show resolved Hide resolved
@samiib samiib force-pushed the pkitp_cert_usage branch 2 times, most recently from 849daad to 4de280b Compare November 13, 2024 11:08
shrsr
shrsr requested changes Nov 13, 2024
View reviewed changes
gen/definitions/properties.yaml Outdated Show resolved Hide resolved
gen/templates/resource_example_all_attributes.tf.tmpl Outdated Show resolved Hide resolved
@samiib samiib requested a review from shrsr November 15, 2024 03:22
@samiib samiib added the jira-sync Sync this issue to Jira label Nov 15, 2024
@github-actions github-actions bot changed the title [minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) [minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) (DCNE-243) Nov 15, 2024
@samiib samiib added jira-sync Sync this issue to Jira and removed jira-sync Sync this issue to Jira labels Nov 15, 2024
@samiib samiib changed the title [minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) (DCNE-243) [minor_change] Added certificate_usage property to aci_certificate_authority (DCNE-222) Nov 15, 2024
akinross
akinross requested changes Nov 15, 2024
View reviewed changes
internal/provider/resource_aci_certificate_authority.go Show resolved Hide resolved
docs/resources/certificate_authority.md Outdated
@@ -185,6 +187,9 @@ All examples for the Certificate Authority resource can be found in the [example
- Default: `uni/userext/pkiext`
* `annotation` (annotation) - (string) The annotation of the Certificate Authority object.
- Default: `orchestrator:terraform`
* `certificate_usage` (certUsage) - (list) The certificate usage of the Certificate Authority object.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we elaborate the description a bit more? Since in then inputs are also abbreviations it might be better to provide a bit more explanation.

akinross
akinross approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit c0dbca1 into CiscoDevNet:master Nov 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees

@samiib samiib

Labels
enhancement jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@samiib @codecov-commenter @lhercot @shrsr @akinross @anvitha-jain @gmicol