-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539
Open
gmicol
wants to merge
11
commits into
CiscoDevNet:master
Choose a base branch
from
gmicol:mso_port_channel_interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8f1b4d2
[minor_change] Add ndo_port_channel_interface as a new module.
gmicol bc02902
[ignore] Modify logic in ndo_port_channel_interface and add a test case.
gmicol c391ae5
[ignore] Update Documentation and test case for ndo_port_channel_inte…
gmicol 17aae26
[ignore] Modify Documentation for ndo_port_channel_interface. Add fla…
gmicol be82f30
[ignore] Modify Documentation and idempotency check for interfaces in…
gmicol 2a6768e
[ignore] Extend update interfaces task by adding more complex ranges …
gmicol ae97cdc
[ignore] Optimize for loops for ndo_port_channel_interface and Move l…
gmicol 08e6c58
[ignore] Remove unecessary flags to check errors. Modify policy attri…
gmicol 05640e1
[ignore] Add function in module_utils/mso.py to format interface_desc…
gmicol 23b361d
[ignore] Add a few extra assessments in test file for ndo_port_chann
gmicol db77679
[ignore] Changed logics, Documentation and Example sections in ndo_po…
gmicol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this function in
mso.py
? If not, move it to the module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will be using it in three different modules, Physical, Port Channel and VPC interfaces. that's why it's currently in
mso.py
as the default script to place our generic functions.