Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

gmicol · 2024-09-27T17:56:11Z

resolves #466

New Modules Added:

ndo_port_channel_interface

gmicol · 2024-10-07T17:27:03Z

To all reviewers, the test is not complete yet as I am waiting for the ndo_interface_setting module to be merged. Please review accordingly. thanks!

plugins/modules/ndo_port_channel_interface.py

tests/integration/targets/ndo_port_channel_interface/tasks/main.yml

plugins/modules/ndo_port_channel_interface.py

tests/integration/targets/ndo_port_channel_interface/tasks/main.yml

plugins/modules/ndo_port_channel_interface.py

plugins/module_utils/mso.py

plugins/modules/ndo_port_channel_interface.py

codecov · 2024-10-23T20:54:37Z

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (4fa9818) to head (108465f).

Files with missing lines	Patch %	Lines
plugins/module_utils/mso.py	6.25%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   80.85%   80.31%   -0.54%     
==========================================
  Files          63       62       -1     
  Lines        6058     5999      -59     
  Branches     1594     1581      -13     
==========================================
- Hits         4898     4818      -80     
- Misses        806      827      +21     
  Partials      354      354

Flag	Coverage Δ
integration	`80.31% <6.25%> (-0.54%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiib

LGTM

akinross

LGTM

akinross

LGTM

sajagana · 2024-11-11T14:50:31Z

plugins/module_utils/mso.py

@@ -318,6 +318,19 @@ def write_file(module, url, dest, content, resp, tmpsrc=None):
    os.remove(tmpsrc)


+def format_interface_descriptions(interface_descriptions, node=None):


Do we use this function in mso.py? If not, move it to the module.

we will be using it in three different modules, Physical, Port Channel and VPC interfaces. that's why it's currently in mso.py as the default script to place our generic functions.

plugins/modules/ndo_port_channel_interface.py

…rface.

…gs to check valid interfaces and descriptions inputs.

… ndo_port_channel_interface.

…of interfaces for the test case of ndo_port_channel_interface.

…ookup_valid_interfaces function to mso.py from module_utils.

…bute. Add new function in module_utils/template to catch interface policy group uuid. Modify test case and Documentation.

…riptions for payload data. Modify Documentation and add more examples using uuid.

el_interfaces.

akinross · 2024-11-15T07:38:41Z

plugins/modules/ndo_port_channel_interface.py

+                ops.append(dict(op="replace", path="{0}/{1}/name".format(path, match.index), value=name))
+                proposed_payload["name"] = name
+
+            if description is not None and mso.existing.get("description") != description:


@sajagana wrote a function for this, asked him to do a separate PR for it so we can rebase the open PRs on it. Shoudl we do this?
https://github.com/CiscoDevNet/ansible-mso/pull/563/files#diff-f3e3720de5c754cfeb714aa1ed0f9d0a1a043f8c0005944d58565decefe1817bR31

yeah, let's do it like this. will rebase on this PR once merged.

plugins/modules/ndo_port_channel_interface.py

anvitha-jain

LGTM

plugins/modules/ndo_port_channel_interface.py

…rt_channel_interface.py module to be consistent with future modules.

gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Sep 27, 2024

gmicol self-assigned this Sep 27, 2024

gmicol force-pushed the mso_port_channel_interface branch from 6a28890 to 5016d36 Compare October 7, 2024 17:07

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib October 7, 2024 17:27

akinross requested changes Oct 8, 2024

View reviewed changes

gmicol force-pushed the mso_port_channel_interface branch from 8a0ef1a to 7f88d0a Compare October 11, 2024 14:39

gmicol requested a review from akinross October 11, 2024 14:39

akinross requested changes Oct 14, 2024

View reviewed changes

gmicol requested a review from akinross October 15, 2024 17:50

anvitha-jain requested changes Oct 18, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

shrsr requested changes Oct 18, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

gmicol force-pushed the mso_port_channel_interface branch from 0af57d3 to d5a18f8 Compare October 21, 2024 17:54

gmicol requested review from shrsr and anvitha-jain October 21, 2024 17:55

gmicol force-pushed the mso_port_channel_interface branch 2 times, most recently from 027e458 to eb8cf29 Compare October 21, 2024 17:58

samiib requested changes Oct 23, 2024

View reviewed changes

plugins/module_utils/mso.py Outdated Show resolved Hide resolved

plugins/modules/ndo_port_channel_interface.py Show resolved Hide resolved

gmicol requested a review from samiib October 23, 2024 17:15

gmicol force-pushed the mso_port_channel_interface branch from eb8cf29 to 108465f Compare October 23, 2024 17:38

samiib previously approved these changes Oct 24, 2024

View reviewed changes

akinross previously approved these changes Oct 24, 2024

View reviewed changes

akinross previously approved these changes Nov 5, 2024

View reviewed changes

anvitha-jain mentioned this pull request Nov 6, 2024

[minor_changes] Adding new module for physical interface (DCNE-50) #560

Open

gmicol dismissed stale reviews from akinross and samiib via 2a3f188 November 8, 2024 18:37

gmicol force-pushed the mso_port_channel_interface branch from a8b89a9 to 2a3f188 Compare November 8, 2024 18:37

gmicol requested review from samiib and akinross November 8, 2024 18:37

sajagana requested changes Nov 11, 2024

View reviewed changes

gmicol added 10 commits November 13, 2024 13:39

[minor_change] Add ndo_port_channel_interface as a new module.

8f1b4d2

[ignore] Modify logic in ndo_port_channel_interface and add a test case.

bc02902

[ignore] Update Documentation and test case for ndo_port_channel_inte…

c391ae5

…rface.

[ignore] Modify Documentation for ndo_port_channel_interface. Add fla…

17aae26

…gs to check valid interfaces and descriptions inputs.

[ignore] Modify Documentation and idempotency check for interfaces in…

be82f30

… ndo_port_channel_interface.

[ignore] Extend update interfaces task by adding more complex ranges …

2a6768e

…of interfaces for the test case of ndo_port_channel_interface.

[ignore] Optimize for loops for ndo_port_channel_interface and Move l…

ae97cdc

…ookup_valid_interfaces function to mso.py from module_utils.

[ignore] Remove unecessary flags to check errors. Modify policy attri…

08e6c58

…bute. Add new function in module_utils/template to catch interface policy group uuid. Modify test case and Documentation.

[ignore] Add function in module_utils/mso.py to format interface_desc…

05640e1

…riptions for payload data. Modify Documentation and add more examples using uuid.

[ignore] Add a few extra assessments in test file for ndo_port_chann

23b361d

el_interfaces.

gmicol force-pushed the mso_port_channel_interface branch from 2a3f188 to 23b361d Compare November 13, 2024 18:39

gmicol requested a review from sajagana November 13, 2024 18:39

akinross requested changes Nov 15, 2024

View reviewed changes

gmicol requested a review from akinross November 19, 2024 18:47

shrsr requested changes Nov 19, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Show resolved Hide resolved

gmicol force-pushed the mso_port_channel_interface branch from 74c318d to eebecde Compare November 20, 2024 18:50

gmicol requested a review from shrsr November 20, 2024 18:50

gmicol force-pushed the mso_port_channel_interface branch from eebecde to 4cd31f2 Compare November 20, 2024 19:02

anvitha-jain approved these changes Nov 21, 2024

View reviewed changes

anvitha-jain requested changes Nov 21, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

[ignore] Changed logics, Documentation and Example sections in ndo_po…

db77679

…rt_channel_interface.py module to be consistent with future modules.

gmicol force-pushed the mso_port_channel_interface branch from 4cd31f2 to db77679 Compare November 22, 2024 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

gmicol commented Sep 27, 2024

gmicol commented Oct 7, 2024

codecov bot commented Oct 23, 2024

samiib left a comment

akinross left a comment

akinross left a comment

sajagana Nov 11, 2024

gmicol Nov 12, 2024

akinross Nov 15, 2024

gmicol Nov 19, 2024

anvitha-jain left a comment

		@@ -318,6 +318,19 @@ def write_file(module, url, dest, content, resp, tmpsrc=None):
		os.remove(tmpsrc)


		def format_interface_descriptions(interface_descriptions, node=None):

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Are you sure you want to change the base?

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Conversation

gmicol commented Sep 27, 2024

gmicol commented Oct 7, 2024

codecov bot commented Oct 23, 2024

Codecov Report

samiib left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

sajagana Nov 11, 2024

Choose a reason for hiding this comment

gmicol Nov 12, 2024

Choose a reason for hiding this comment

akinross Nov 15, 2024

Choose a reason for hiding this comment

gmicol Nov 19, 2024

Choose a reason for hiding this comment

anvitha-jain left a comment

Choose a reason for hiding this comment