Implementation - csv-delimiter #165
Conversation
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "globals": { | |||
| "onlyCreateWhitelisted": true | |||
| "onlyCreateWhitelisted": true, | |||
There was a problem hiding this comment.
remove onlyCreateWhitelist changes from this PR.
| './test/fixtures/test-csvs/csvreader/invalid.reader.csv' | ||
| ); | ||
|
|
||
| expect(res).toBeDefined(); |
There was a problem hiding this comment.
don't only check the result to be defined, since you are parsing with a different delimiter, make sure it is parsed correctly.
| export function getCsvDelimiter(configPath: string): string | undefined { | ||
| try { | ||
| const configContent = fs1.readFileSync(configPath, 'utf-8'); | ||
| const config = JSON.parse(configContent); |
There was a problem hiding this comment.
JSON.parse() has the potential to throw an error, wrap this is in a try-catch
| try { | ||
| const configContent = fs1.readFileSync(configPath, 'utf-8'); | ||
| const config = JSON.parse(configContent); | ||
| return config.globals.csvDelimiter; |
There was a problem hiding this comment.
handle errors here as well, there is no gurantee that this particular element is defined or not. Also make sure you are handling the case of this function returning as undefined wherever it is being being and defaulting to a ',' in such cases.
| @@ -3,13 +3,20 @@ const fs = require('fs').promises; | |||
|
|
|||
| import * as csv from 'csv-parser'; | |||
|
|
|||
| export async function readCSV(filePath: string): Promise<string[][]> { | |||
| export async function readCSV(filePath: string, configPath?: string, delimiter?: string): Promise<string[][]> { | |||
There was a problem hiding this comment.
don't pass in configPath to a utility function like this. Read the required paramters (delimiter in this case) at the initial top level when the config is parsed and pass in the delimiter from there only.
Added new config parameter along with test cases to increase coverage ( For the issue #64 )