Implement FKSearch #131
Open
Implement FKSearch #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented Fksearch on a sample data. Added a sample test and git expected output. Though need to figure out on how to apply in cqube dataset
techsavvyash
reviewed
Aug 1, 2023
| @@ -11,7 +12,11 @@ export async function readCSV(filePath: string): Promise<string[][]> { | |||
| .createReadStream(filePath) | |||
| .pipe(csv({ separator: ',', headers: false, quote: "'" })) | |||
| .on('data', (data) => { | |||
| rows.push(Object.values(data)); | |||
| const rowValues: string[] = Object.values(data); | |||
There was a problem hiding this comment.
how is this logic ensuring that case insesitivity is achieved? What if the dimensions table has a value "CQUBE" and caseSensitiveFKSearch flag is set to false and then the CSV has cqube, ideally as per the issue description this case should pass whereas in my understanding with the implementation in this PR, it will fail. Am I missing something here?
techsavvyash
requested changes
Oct 7, 2023
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "globals": { | |||
| "onlyCreateWhitelisted": true | |||
| "onlyCreateWhitelisted": true, | |||
There was a problem hiding this comment.
don't let the onlyCreateWhiteList changes come into this PR.
Pull Request Test Coverage Report for Build 5643721587Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Fksearch on data as part of C4GT issue. #63