Manage collaborators #24

git-voo · 2024-09-04T16:17:13Z

Implemented

View the list of contributors
invite a new member
remove member (from UI)
error display on UI
permissions:
- only the Owner and Leader can view the remove button
- only the Owner and Leader can add new members

Pending Implementation

- remove member from DB
- revoke member role
move base URL to central point (env?)
move add/remove member functions to Project class
move getProject method to Project class

Create New Issue For

populate the Collaboration tab with Project title and group title
Populate project list with DB data

cubap

Some comments. I'll let you finish it.

manage/collaboration.html

cubap · 2024-09-04T19:18:56Z

collaborators/index.mjs

+
+let isOwnerOrLeader = false;
+let projectID;
+let testToken = "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6Ik9FVTBORFk0T1RVNVJrRXlOREl5TTBFMU1FVXdNMFUyT0RGQk9UaEZSa1JDTXpnek1FSTRNdyJ9.eyJodHRwOi8vc3RvcmUucmVydW0uaW8vYWdlbnQiOiJodHRwczovL3N0b3JlLnJlcnVtLmlvL3YxL2lkLzY1Zjg2MTVlYzQzYmQ2NjU2OGM2NjZmYSIsImh0dHA6Ly9yZXJ1bS5pby9hcHBfZmxhZyI6WyJ0cGVuIiwiZGxhIl0sImh0dHA6Ly9kdW5iYXIucmVydW0uaW8vYXBwX2ZsYWciOlsidHBlbiIsImRsYSJdLCJodHRwOi8vcmVydW0uaW8vdXNlcl9yb2xlcyI6eyJyb2xlcyI6WyJkdW5iYXJfdXNlcl9wdWJsaWMiLCJnbG9zc2luZ191c2VyX3B1YmxpYyIsImxyZGFfdXNlcl9wdWJsaWMiLCJyZXJ1bV91c2VyX3B1YmxpYyIsInRwZW5fdXNlcl9hZG1pbiIsInRwZW5fdXNlcl9pbmFjdGl2ZSJdfSwiaHR0cDovL2R1bmJhci5yZXJ1bS5pby91c2VyX3JvbGVzIjp7InJvbGVzIjpbImR1bmJhcl91c2VyX3B1YmxpYyIsImdsb3NzaW5nX3VzZXJfcHVibGljIiwibHJkYV91c2VyX3B1YmxpYyIsInJlcnVtX3VzZXJfcHVibGljIiwidHBlbl91c2VyX2FkbWluIiwidHBlbl91c2VyX2luYWN0aXZlIl19LCJpc3MiOiJodHRwczovL2N1YmFwLmF1dGgwLmNvbS8iLCJzdWIiOiJhdXRoMHw2NWY4NjE1ZDZjNmJlYjIzMTVjZWY4MjIiLCJhdWQiOlsiaHR0cHM6Ly9jdWJhcC5hdXRoMC5jb20vYXBpL3YyLyIsImh0dHBzOi8vY3ViYXAuYXV0aDAuY29tL3VzZXJpbmZvIl0sImlhdCI6MTcyNTQ1ODg1NywiZXhwIjoxNzI1NDY2MDU3LCJzY29wZSI6Im9wZW5pZCBwcm9maWxlIGVtYWlsIHVwZGF0ZTpjdXJyZW50X3VzZXJfbWV0YWRhdGEgb2ZmbGluZV9hY2Nlc3MiLCJhenAiOiJiQnVnRk1XSFVvMU9oblNaTXBZVVh4aTNZMVVKSTdLbCJ9.D06LUWxeS2HKibY3sLxe18f7n3b56PifEGaoGriPDqkvsIG077Sa9qn-6WZCguw3TFSGKN0GG6YM9Gd8hGdXkPB3gEpYSlAzwZwHZzvs3bV1dPBE6zSkL1Z_lTyVXyhjh13oCJx73Y66DjjZkuLGvVG7_IEC7OF9njYAF5MgqgvyQZlSTKpOnxgu76S7SNjrecnMscMLNASe6fDSeH7NUXP3HEhYuy1dbBV_pVaxFZLIjx5-KHNCHs4LvuybSmm0GWt6HyRTpi69AsA_rSGDcW9rzLZSCGRWr1fN4WOWKbM-Lwpdt_0ir_djQmbkrnk9sO4FQ7P5ZmQD_vAoPTPGWQ"


okay for a test, but for the PR, this needs to use the auth and login so that it is a portable interface.

I may need to work with you on that @cubap I'm still getting a 400 from auth0 on login/logout from interfaces

collaborators/index.html

cubap · 2024-09-04T19:24:28Z

manage/collaboration.html

These do not really need to look like TPEN28 and it might be harder to reskin it later if it has more than what it needs to be basically functional.

collaborators/index.mjs

css/collaborators/index.css

cubap · 2024-10-25T20:37:11Z

so much good work here, but I think we need to eliminate some of the redundancies. You've already got this instinct. I'm seeing some things that are in /iiif-tools and the auth struggles should be handled already. I'm going to go PR something real quick...

cubap · 2024-10-25T20:43:31Z

_site/api/project.mjs

This directory shouldn't be versioned

* logout redirect hotfix * logout redirect hotfix * Tpen class (#36) * Update index.mjs bad merge added local env * Create index.mjs * TPEN class with authentication * match docs to class * swap out auth * adding expiry * cleaning up the auth * Add tpen class auth to transcription (#37) * replacing URLsafed chars with base64 equiv * working with new auth * removing excess * error handling * moving the file to a Class * Starting here. * auth is for TPEN * userMessages * notes * get User out of TPEN * collaborators updated. --------- Co-authored-by: Bryan Haberberger <[email protected]>

…TPEN-interfaces into manage-collaborators

TPEN/index.mjs

cubap · 2024-11-11T21:10:59Z

TPEN/index.mjs

@@ -41,8 +40,8 @@ export default class TPEN {
    }

    set currentUser(user) {
-        // confirm user is a User object
-        if (!user.displayName || !user._id) {


I think this || is so an unloaded User is never entered in as "#currentUser"

TPEN/index.mjs

_site/api/project.mjs

api/project.mjs

index.html

cubap · 2024-11-11T21:51:51Z

manage/projectsHighlight.mjs

 import getActiveProject from "../utilities/getActiveProject.mjs"
 import getHash from "../utilities/getHash.mjs"

-
 async function fetchProjects() {


seems like a chance to use the Project Class you made.

utilities/checkUserAuthentication.mjs

…TPEN-interfaces into manage-collaborators

…gitalHumanities/TPEN-interfaces into manage-collaborators

services isn't passing displayName back yet.

thehabes

It would be nice if the projects in the project list were clickable to load them up by their id.

Noting it is not possible to delete an item in the project list. I was informed the API is not ready for that yet, so this makes sense.

In user management I am not able to remove members from a group or change their roles (as an OWNER and/or a LEADER)

In user management I get a conflicting message when I try to add/invite a new member. The Network says 403 Forbidden. Pagination says other things.

/components/user-profile does not load, but the index.html component does.

/components/manage-collaborators is empty and should probably be removed to avoid confusion.

I am suspicious of seeing the instances of these two things together...is one of them wrong

TPEN_USER.authentication
TPEN_USER.authorization

This may allude to a need for a small "how do we get the bearer token" refactor in files that have not been adjusted for the TPEN and User class stuff. The approach does not appear to be synchronized across the files.

manage/index.mjs

thehabes · 2024-11-19T18:13:27Z

components/projects-list/index.mjs

@@ -28,7 +28,7 @@ export default class ProjectsList extends HTMLElement {
            if (oldValue !== newValue) {
                const loadedUser = new User(newValue)
                loadedUser.authentication = TPEN.getAuthorization()


authentication vs authorization. There are instances where this is set like TPEN_USER.authorization. It looks like a difference between TPEN.getAuthorization and checkUserAuthentication and maybe this is right.

/components/user-profile does not load, but the index.html component does.

fix posted to watch for user-id change if it is the only component on the page

getAuthorization() is for consistency from TPEN_USER. Strictly speaking, we are getting the idToken, so a refactored name makes sense. That said. This isn't the place for it. Someone can mention this in a new issue, I suppose.

git-voo · 2024-11-25T17:01:22Z

The UI update for addMember is currently being delayed because of the delayed/no response from the SMTP server since it sends emails. It'd be fixed once the server is back up.

add manage collaborators

fd228a8

git-voo added the core functionality label Sep 4, 2024

git-voo requested a review from cubap September 4, 2024 16:17

git-voo self-assigned this Sep 4, 2024

cubap reviewed Sep 4, 2024

View reviewed changes

git-voo and others added 8 commits September 11, 2024 00:45

fix PR comments

e01c768

Refactor permision-based visibility of elements

4370ee2

Add live data for project and collaborators details on /manage/*

b92f241

Add auth button and script

4af35d4

authenticate projectsHighlights and projects listing

921416c

get authorization from TPEN_User

2e344d8

main merge

a6e3b6f

Merge branch 'main' into manage-collaborators

23a289e

cubap reviewed Oct 25, 2024

View reviewed changes

_site/api/project.mjs

Copy link

Member

cubap Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory shouldn't be versioned

cubap and others added 3 commits November 4, 2024 20:26

fix import path error

f8535d3

Merge branch 'main' of https://github.com/CenterForDigitalHumanities/…

9d3c0f0

…TPEN-interfaces into manage-collaborators

git-voo marked this pull request as ready for review November 11, 2024 16:54

git-voo requested a review from cubap November 11, 2024 16:54

cubap requested changes Nov 11, 2024

View reviewed changes

git-voo added 2 commits November 12, 2024 12:56

Merge branch 'main' of https://github.com/CenterForDigitalHumanities/…

7bb1da4

…TPEN-interfaces into manage-collaborators

quick fix

9604626

git-voo force-pushed the manage-collaborators branch from 9d3c0f0 to 9604626 Compare November 12, 2024 18:57

thehabes and others added 6 commits November 13, 2024 15:17

use the new public-login component for the auth-button.

522ecf5

new login button on /projects

8274279

Merge branch 'manage-collaborators' of https://github.com/CenterForDi…

b8f9d01

…gitalHumanities/TPEN-interfaces into manage-collaborators

Merge branch 'manage-collaborators' of https://github.com/CenterForDi…

d111221

…gitalHumanities/TPEN-interfaces into manage-collaborators

listing

7146b7b

rough - in progress

cacd407

cubap and others added 9 commits November 14, 2024 16:03

up and running

a787704

Update index.html

9050ec6

helpful cheat

9ffe8c0

bad User error fixed

1b5d369

contributer > collaborator

782912f

working if you want it.

81a4d99

services isn't passing displayName back yet.

null check

e12e7ed

This is definitely wrong

4bd006b

touch up loading behavior

3349686

thehabes reviewed Nov 19, 2024

View reviewed changes

cubap and others added 4 commits November 19, 2024 13:49

Watch for user-id changes

3a76a16

fix add/remove contributor

97317d8

hotfix remove error

85a90c7

update UI after removal

0a5092f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manage collaborators #24

Manage collaborators #24

git-voo commented Sep 4, 2024 •

edited

Loading

cubap left a comment

cubap Sep 4, 2024

git-voo Sep 5, 2024

cubap Sep 4, 2024

cubap commented Oct 25, 2024

cubap Oct 25, 2024

cubap Nov 11, 2024

cubap Nov 11, 2024

thehabes left a comment •

edited

Loading

thehabes Nov 19, 2024

cubap Nov 19, 2024

cubap Nov 19, 2024

git-voo commented Nov 25, 2024

Manage collaborators #24

Are you sure you want to change the base?

Manage collaborators #24

Conversation

git-voo commented Sep 4, 2024 • edited Loading

cubap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cubap commented Oct 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thehabes left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

git-voo commented Nov 25, 2024

git-voo commented Sep 4, 2024 •

edited

Loading

thehabes left a comment •

edited

Loading