mizar preliminary installation not to install binary #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-w-chen
requested review from
Sindica,
sonyafenge,
q131172019 and
Hong-Chang
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sindica The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sindica
reviewed
Feb 24, 2022
| chmod +x ${KUBE_BIN}/mizarcni | ||
| #BUGBUG: This is a hack around arktos runtime hardcoding of CNI bin dir | ||
| # create folder only here | ||
| # mizar will be installed via daemonset or other means later |
There was a problem hiding this comment.
Please rename install-mizar-cni-bin
h-w-chen
deleted the
hw-mizar-premilinary-installation-has-no-binary-installaed
branch
sonyafenge
pushed a commit
to sonyafenge/arktos
that referenced
this pull request
Feb 28, 2022
sonyafenge
pushed a commit
to sonyafenge/arktos
that referenced
this pull request
Feb 28, 2022
centaurus-cloud-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
* kube-proxy of rp nodes connecting to tp masters (#1351) * Mizar-Arktos integration with multitenancy network isolation for n-TP x n-RP scale out architecture (#1320) * Mizar-Arktos integration with multitenancy network isolation * Deploy Mizar daemon as DaemonSet while keeping operator as static pod * Source Mizar CRDs, daemon, and operator yaml files from arktos repo Co-authored-by: Sonya Li <[email protected]> * Use in-cluster config for Mizar operator Co-authored-by: Sonya Li <[email protected]> * Deploy mizar daemon and operator after tp and rp ready (#1363) * mizar preliminary installtion does not have binary installed (#1381) Co-authored-by: hwchen <[email protected]> Co-authored-by: Vinay Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is part of fixes to #1357. The more important fix is from mizar:dev side. This PR only solves the kube-up scale-out preliminary step related issue.
As the preliminary step, it does not download mizar cni binary and have it installed. Instead, it only ensures the cni binary folder is there. The full-fledged mizar installation will be done by daemonset or other means.
With this change, kubelet will not invoke the possibly polluted cni binary before the proper mizar parts are there.
Which issue(s) this PR fixes:
Fixes #1357
Special notes for your reviewer:
Does this PR introduce a user-facing change?: