FIREFLY-1607: Server-side implementation of Healpix index #1668
+615
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create deg2pix UDF - create HealpixProcessor - create HealpixProcessorTest - enable json error log for better duckdb error message
robyww
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Well, I am really impressed. Implementing the healpix pixel computation as a sql function!
I have no idea how any of it works or how you are thinking we will use it; so we need to talk and you can walk me though your ideas.
I am guessing somewhere you return healpix index and counts at some level… I don’t know if there is a place that takes a query for a set of indexes.
Anyway we need to talk about it when I get back. I have some specific ideas what the calls should look like.
I am fine if you want to merge or you can wait until I get back. After we talk you might need to do a second PR.
| END AS pixel | ||
| FROM step_f | ||
| ); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1607