-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add attribute hover style is not applied #66
Conversation
setTimeout(() => { | ||
// update detail after timeout time global and current optionId is equal | ||
if (d.optionId === this._geneHoverOptionId) { | ||
this._mouseOverHandler(d, event.currentTarget); | ||
this._mouseOverHandler(d, currentTarget); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not be necessary, but you can also use it on line 311.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 311 only handles the case for non-genes. Ollie fixed the gene case here and the event might not be available after the timeout is executed. So I agree with the fix he proposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is fixed with your changes.
setTimeout(() => { | ||
// update detail after timeout time global and current optionId is equal | ||
if (d.optionId === this._geneHoverOptionId) { | ||
this._mouseOverHandler(d, event.currentTarget); | ||
this._mouseOverHandler(d, currentTarget); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 311 only handles the case for non-genes. Ollie fixed the gene case here and the event might not be available after the timeout is executed. So I agree with the fix he proposed.
Closes https://github.com/Caleydo/cohort/issues/718
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
event.currentTarget
being null by the time thesetTimeout
is executedScreenshots
before
after
Additional notes for the reviewer(s)
Thanks for creating this pull request 🤗