Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked leaves textures as well as adding waterlogging support. #2512

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

TheNukeLore
Copy link

@TheNukeLore TheNukeLore commented May 20, 2024

Remade the better leaf system from scratch, and alongside that, I included an experimental waterlogging system that helps people visually see waterlogged leaves with fast graphics.

What's currently included:

  • Support for all leaves
  • Waterlogged blockstates for leaves
  • Programmer art leaves

Known and/or potential issues:

  • Waterlogged leaves texture will likely override other resource packs texture unless they specifically add waterlogging support to said pack.
  • Waterlogged programmer art leaves revert back to non-programmer art leaves due to the issue mentioned above.

Something to note: For packs to add support for waterlogged leaves, they will need to add a folder called "waterlogged" in "textures/block/". In that folder, they can add their own form of waterlogged leaves or simply copy their existing texture there if they don't care to support waterlogged leaves on fast graphics.

When it comes to models, most models should simply work, as they are only replacing the texture. There is a niche case where it could still break, but it is extremely unlikely.

If requested, I may remove waterlogged support due to the issues that it can cause.

@TheNukeLore
Copy link
Author

These changes:
2024-05-19_20 49 24
Current sodium(uses vanilla tweaks leaves):
2024-05-19_20 53 19
There is partial support for programmer art leaves. however they have a few issues when it comes to water-logging, may look back into that issue as it also affects external packs. image showing the issue at hand:
2024-05-19_20 54 26
Should be noted that non of my changes copy or use assets from Vanilla Tweaks, these are all manually made using the base leaf textures.

@jellysquid3
Copy link
Member

I'm not okay with breaking resource pack compatibility for adding waterlogged textures into the game. For the most part, we don't even encourage using Fast Graphics mode since it offers little to no performance improvement and introduces all kinds of issues with texture handling.

@jellysquid3
Copy link
Member

That said, can you please elaborate on how you "improved" the existing textures? I don't see much of a difference from the screenshots given. There are bugs like #2422 but I don't actually understand what is described or if your pull request fixes this.

@TheNukeLore
Copy link
Author

My textures are not inherently better just done in a consistent method, They were more so made in a methodology that avoided copying any part of vanilla tweaks to avoid any potential concerns of copying(cleanroom per say), however the programmer art leaves should be the most updated ones possible, they uses the latest assets from programmer art in 1.20.6. I can update this pr with the removal of water logging blockstates/textures if you still would like the other aspects.

@jellysquid3
Copy link
Member

If you can create a new pull request with just the changes that update the Leaves textures, that would be appreciated. Let's not change the purpose of this pull request in case it's useful in the future.

@TheNukeLore
Copy link
Author

That includes both regular and programmer art textures correct?

@jellysquid3
Copy link
Member

Yes, both sets of textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants