-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cruft link #144
Cruft link #144
Conversation
pyproject.toml
Outdated
"sphinx-automodapi", | ||
"tomli; python_version <\"3.11\"", | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the template so empty line happy here, we should address that upstream
pyproject.toml
Outdated
|
||
|
||
[project.urls] | ||
repository = "https://parfive.readthedocs.io/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, looks like a template bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats the url to the docs not the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's happened here, all the template stuff looks to be in good order, did I just mess up the input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Homepage =
for more information, see https://pre-commit.ci
setup.py
Outdated
|
||
setup( | ||
|
||
) | ||
setup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CyclingNinja This change should also be fixed in the template. rendering with a blank line like that is gross.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed, I'm wondering how it even happened
Co-authored-by: Stuart Mumford <[email protected]>
Co-authored-by: Stuart Mumford <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 5 5
Lines 635 635
=======================================
Hits 573 573
Misses 62 62 ☔ View full report in Codecov by Sentry. |
b8b59d5
to
250dcec
Compare
for more information, see https://pre-commit.ci
No description provided.