Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cruft link #144

Closed
wants to merge 15 commits into from
Closed

Cruft link #144

wants to merge 15 commits into from

Conversation

CyclingNinja
Copy link

No description provided.

.cruft.json Outdated Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated
"sphinx-automodapi",
"tomli; python_version <\"3.11\"",
]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the template so empty line happy here, we should address that upstream

pyproject.toml Outdated


[project.urls]
repository = "https://parfive.readthedocs.io/"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, looks like a template bug

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats the url to the docs not the repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's happened here, all the template stuff looks to be in good order, did I just mess up the input?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Homepage =

pyproject.toml Outdated Show resolved Hide resolved
setup.py Outdated

setup(

)
setup()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyclingNinja This change should also be fixed in the template. rendering with a blank line like that is gross.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, I'm wondering how it even happened

CyclingNinja and others added 2 commits January 16, 2024 12:06
Co-authored-by: Stuart Mumford <[email protected]>
Co-authored-by: Stuart Mumford <[email protected]>
.gitignore Show resolved Hide resolved
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a25de0d) 90.23% compared to head (b8b59d5) 90.23%.

❗ Current head b8b59d5 differs from pull request most recent head 37eb1a9. Consider uploading reports for the commit 37eb1a9 to get more accurate results

Files Patch % Lines
parfive/downloader.py 90.90% 1 Missing ⚠️
parfive/results.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files           5        5           
  Lines         635      635           
=======================================
  Hits          573      573           
  Misses         62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants