-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel forced alignment #319
base: master
Are you sure you want to change the base?
Conversation
Hello @m-toman,
Any thoughts? |
@m-toman must have done it so well that he also replaced the ugly sed-based arguments replacement by proper command line arguments :) |
UPDATE: So changing the below two lines of code seems to fix it in all other egs than 'speaker-adaptation'. This one still throws the above error message, unless you run each script individually in the merlin/misc/scripts/alignment/state-align folder. Hello @gillesdegottex and @m-toman! It seems that the bug for me was in line 414: This line deemed it impossible to run the script without giving it a command-line argument. I changed both line 414 and 419 to: |
You are right, I forgot that python holds the script name in argv[0] when I added then len() ifs. I tried to name the hacky temporary variables below that so that they are not hit by the sed replace but the script still works without parameters. Regarding the speaker adaptation script, I think this should work with the new version: |
Hey @m-toman! Thanks, I will try the run_state_align fix. However, I run into the following error message, when I try to run the run_aligner script in the merlin/misc/scripts/alignment/state_align folder. It looks as if it is right after the feature normalisation, when I reach the "--making proto" step.
|
Could you output the parameters for HCompV before the call here https://github.com/m-toman/merlin/blob/master/misc/scripts/alignment/state_align/forced_alignment.py |
Hello @m-toman! How do i find the parameters for HCompV? I have run the prepare_labels_from_text.sh script, and the next script is now forced_alignment. Best Regards, |
@martedva I just meant something simple as: the error above sounds to me as if the file self.train_scp points to is not a list of files as expected. |
Hello @m-toman! Sorry for the late response. I have been trying to fix the issues. It seems that it is indeed the sed replacements, that was culprit. I used a fixed path instead and fixed it. Thanks, |
@martedva great, so is there something I can do in this PR or was that a fix in the outer scripts? |
Hey @m-toman, It seemed, that the sed-replacements resulted in setting both of these paths to being empty. I therefore ran the scripts individually and reset the paths in forced_alignment.py just before running it as shown below. work_dir = "/home/tts/merlin/misc/scripts/alignment/state_align"
work_real_dir = work_dir
if len(sys.argv) > 2:
htk_dir = sys.argv[2]
else:
#this HTK path
HTKDIR = "/home/tts/merlin/tools/bin/htk"
htk_dir = HTKDIR
#this wav path
wav_dir = "/home/tts/merlin/egs/speaker_adaptation/s1/database/wav" Does that make sense? |
sorry to bother in 2019, I just come across the same issue with HcomPv and I can't understand the comments. what's sed replacements mean? which fixed path did you use to fix the issue and how to modify this path? |
I can't find this part of code in forced_alignment.py , should I just add it ?(add to where?)
|
This PR solves "ERROR [+7031] during forced_alignment.py" as dicussed in #293.
List of changes:
I've tested the latest script in my environment with a 4000 sentence corpus, please report if this breaks any example scripts, which could happen for some sed reasons (pun intended).