Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed tasks #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shriya-tiwari
Copy link

@shriya-tiwari shriya-tiwari commented Jul 1, 2022

Tasks:

  • Login Function
  • Auth Middleware
  • Add task
  • Get tasks
  • Update Task
  • Delete Task
  • UI Improvement - added CSS list transitions

Deployment link

Copy link
Member

@yash-yp yash-yp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good attempt!

I have addressed a few concerns in the comments

@@ -0,0 +1,3 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the use of .gitignore to prevent commiting unwanted files

@@ -3,6 +3,7 @@
<label for="add task" class="flex-1">
<input
type="text"
v-model="taskadded"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read about using the right name convention for Javascript

@@ -1,7 +1,7 @@
<template>
<main class="max-w-lg mx-auto px-6">
<add-task @newTask="getTasks" />
<transition>
<transition name="slide-fade">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use transition groups to apply the effect to each list element

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now applied transition to individual todos but it works only when todo is deleted. When todo is added this transition is not applied because getTask function is called for getting the entire list of todos.


const location = context.route.fullPath
const token = context.store.getters.token
console.log(location)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all console.log() after done debugging


updateTask(_index, _id) {

this.todos[_index].editing = !this.todos[_index].editing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better way to edit would have been to fill edit space with the pre-existing task

state.username === '' ||
state.password === ''
) {
$toast.error('Please enter correct login credentials.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing feedback to user about error will be better ie username/password cannot be empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants