Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main reformat #8

Closed
wants to merge 21 commits into from
Closed

Main reformat #8

wants to merge 21 commits into from

Conversation

daisukes
Copy link
Contributor

  • add CMake test for formatting/unit test
  • add action to run the unit test on pull_request

@daisukes
add cmake test for cabot pacakge, fix format
0c4c195 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_bt package, fix format
ae15748 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_diagnostics package, fix format
ad90630 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_gazebo package, fix format
14627d1 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_mf_localization package
b0330ad 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_navigation2 package, fix format, remove run_…
5311c46 
…test_yaml.py

Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for cabot_ui package, fix format
b572861 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for mf_localization_msgs package, fix format
a13646f 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for mf_localization_rviz package, fix format
8bc2ad4 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for pedestrian_plugin package, fix format
e583027 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
fix format pedestrian_plugin_msgs package
13e219a 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for queue_people_py
0fb5cc6 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
add cmake test for mf_localization package, fix format, remove unnece…
8f2ace0 
…ssary files

Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
fix workflow
48b7130 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
skip test cabot-common packages
9e1dcb8 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes daisukes added the enhancement New feature or request label Feb 25, 2024
@daisukes daisukes self-assigned this Feb 25, 2024
@dsato80
Update run-test.yaml
8ef912f 
make disk space
@dsato80
Update run-test.yaml
c93249c 
remove UID for build
@muratams
Copy link
Contributor

@daisukes
Confirmed that these commits are basically on formatting and running linter as unit tests and they do not affect the behavior of the software. This PR should be merged as soon as possible to avoid conflicts with other changes.

I'd like to ask two points:

  • Can you resolve the existing conflicts?
  • Can you update cabot_navigation2/test/README.md because run_test_yaml.py is removed in this PR.

@daisukes
Merge branch 'main' into main-reformat
6a2da28
@daisukes
test cabot_common, cabot_msgs as well
291276d 
(I don't want to test cabot-common here, but I don't want to put build/test code for cabot-common too)

Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
update README.md
8decebe 
Signed-off-by: Daisuke Sato <[email protected]>
@daisukes
Copy link
Contributor Author

@muratams

Thank you for the review!
I've resolved the conflict and removed the document about run-test-yaml.py
I will merge if the check run gets a successful result!

@daisukes
Copy link
Contributor Author

Hmm, I am not sure what's going on here, I put 3 more commits to fix test, but the PR does not reflect the status.

https://github.com/orgs/community/discussions/16351#discussioncomment-6327770

I will close this and make another.

@daisukes daisukes closed this Feb 26, 2024
@daisukes daisukes mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratams muratams Awaiting requested review from muratams

Assignees

@daisukes daisukes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daisukes @muratams @dsato80