-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary compile definitions #672
Remove unnecessary compile definitions #672
Conversation
f14218d
to
84b0ef9
Compare
1063899
to
7e9b0c9
Compare
cmake/config.hpp.in
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internally to DDC, one has to include this file when the preprocessor macros are used to avoid any surprise
c20122c
to
ddef80a
Compare
3c51b3d
to
52d4b74
Compare
52d4b74
to
9343a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Regarding examples, do you need PDI enabled versions for all examples? Since it is an advanced usage, I think one example is sufficient. Making other examples as simple as possible without PDIs would help beginners.
thanks!
Need, no. It was introduced to be sure we compile the PDI related classes. I don't know yet how to write PDI tests. |
Removed:
target_compile_definitions(DDC INTERFACE "DDC_BUILD_KERNELS_FFT")
target_compile_definitions(DDC INTERFACE "DDC_BUILD_KERNELS_SPLINES")
target_compile_definitions(PDI_Wrapper INTERFACE "DDC_BUILD_PDI_WRAPPER")
target_compile_definitions(DDC INTERFACE DDC_BUILD_DOUBLE_PRECISION)
is replaced by aconfig.hpp.in
file.DDC public headers
<ddc/ddc.hpp>
available using cmake targetDDC::DDC
<ddc/kernels/fft.hpp>
available using cmake targetDDC::DDC
if cmake optionDDC_BUILD_KERNELS_FFT=ON
<ddc/kernels/splines.hpp>
available using cmake targetDDC::DDC
if cmake optionDDC_BUILD_KERNELS_SPLINES=ON
<ddc/pdi.hpp>
available using cmake targetDDC::PDI_Wrapper
if cmake optionDDC_BUILD_PDI_WRAPPER=ON