Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is needed for a general format of netcdf output as in INT2LM #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guydemorsier
Copy link
Contributor

No description provided.

@guydemorsier
Copy link
Contributor Author

launch jenkins

@guydemorsier guydemorsier requested a review from ofuhrer June 4, 2020 19:48
@guydemorsier
Copy link
Contributor Author

@ofuhrer is this also ok for you?

Copy link
Contributor

@ofuhrer ofuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch that.
LGTM.

@kosterried If we could enable TravisCI for the C2SM-RCM organization as #39 is now merged, we could actually see tests of these PRs.

@ofuhrer ofuhrer self-requested a review June 4, 2020 20:02
@guydemorsier
Copy link
Contributor Author

@ofuhrer @kosterried the testsuite can be tested by "Building with Parameters".
This PR is e.g. tested here: http://jenkins-mch.cscs.ch/view/tools/job/testsuite/63/
and is green now which was not the case before.
@ofuhrer the problem was that INT2LM produces files like these:
-rw-r--r-- 1 morsier s83 236535652 Jun 4 17:52 work/climate/ERAI_EUR_12/output/lbfd1979010100.nc
-rw-r--r-- 1 morsier s83 236535652 Jun 4 17:52 work/climate/ERAI_EUR_12/output/lbfd1979010106.nc
And with "l[bf]ff[0-9][0-9].nc" these files are invisible but with ls -l work/climate/ERAI_EUR_12/output/l[bf]f.nc the files are found.

@ofuhrer
Copy link
Contributor

ofuhrer commented Jun 4, 2020

@guydemorsier @kosterried The tests on Jenkins are integration tests (using the testsuite for actually running COSMO and int2lm with actual data). The testsuite now also contains it's own Python tests (type make test in the testsuite directory) which run very rapidly and also run basic unit tests of several testsuite modules without requiring an executable of COSMO or int2lm. These are different tests and I think it would make sense to run these with TravisCI.

@kosterried
Copy link
Contributor

kosterried commented Jun 5, 2020

@ofuhrer "Travis CI for Open Source Projects" was already granted access for the C2SM-RCM organization some time ago because Valentin was using it for CLAW. Can this be used to run the testsuite tests, or do I also need to enable the "Travis CI" third party access as well? It seems redundant to need both of them.

Actually, it seems as though they have migrated the Travis CI for Open Source Projects into the Travis CI name: https://blog.travis-ci.com/2018-05-02-open-source-projects-on-travis-ci-com-with-github-apps
I have enabled access to the Travis CI app. Let me know if I need to do anything else as admin.

@guydemorsier guydemorsier changed the title This is needed for more a general format of netcdf output as in INT2LM This is needed for a general format of netcdf output as in INT2LM Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants