Fix base64 deserialization when using a reader #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Thanks a lot for the fix!
I didn't realise that serde can issue runtime errors like that, even though it makes perfect sense that it needs storage in order to deserialize a stream which wasn't taken into consideration. Quite a footgun, I will try to remember that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case, we deserialize GCP structs using a file reader (instead from an in-memory string), which yields errors such as this:
The first commit demonstrates this behavior, and the second fixes it by allowing
serdeto choose between a borrowed and owned string using aCow.