Add Debug derive to youtube3::api::Scope enum #450
Conversation
Adding that makes logging and debugging easier.
OMGeeky
changed the title
|
I honestly don't really know how to build all things (and if I should?) but even if I should, it generates me a ton of changes with whitespace/line endings so if those should not be committed too I can't really generate it all since I would have to manually select the actual changes on each file etc. If you got anything I should do differently feel free to tell me. I also have no Idea why the check failed, maybe you can give me a hint for that one since it worked locally. |
There was a problem hiding this comment.
CI is once again broken because python casually breaks over time with nothing else changing, or the dependencies that are pulled in do. This is a problem on its own here.
The file edited here is generated, and changes need to be made in the generator or they will be lost next time the file is generated.
The source for it is here if you want to give it another try. Files can be regenerated with make youtube3 (hopefully), and if it doesn't regen after changing the code throw an rm -Rf gen/youtube3 in for good measure.
|
I did (or at least think I did) change the generator file that is at Maybe while were at it we could also add the Clone derive to it since I don't see a reason why it should not be cloneable and the Enum does not contain any data that might not be cloneable |
|
Apologies, I only saw the first line which was a generated file and stopped there.
Yes, please do remove the changes in the generated file do feel free to add more traits now that we are at it. The link also doesn't work for me, strangely enough, but it has no value as it just linked to the generator which you are already aware of. Thanks again. |
|
Thanks a lot! I added even more traits before merging. |
Adding that makes logging and debugging easier.