Add new terms (issue #165) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made changes in button style
Bumps [cookie](https://github.com/jshttp/cookie) to 0.7.2 and updates ancestor dependency [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro). These dependencies need to be updated together. Updates `cookie` from 0.6.0 to 0.7.2 - [Release notes](https://github.com/jshttp/cookie/releases) - [Commits](jshttp/cookie@v0.6.0...v0.7.2) Updates `astro` from 4.14.2 to 4.16.1 - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/[email protected]/packages/astro) --- updated-dependencies: - dependency-name: cookie dependency-type: indirect - dependency-name: astro dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…ti-25240a3bfe Bump cookie and astro
fix: Navbar bug
…ncyclopedia into add-new-terms
Shortened the subtexts and changed some links and structures.
Buzzpy
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Hello again! Thanks for the contributions, I really appreciate it!
I have already fixed the issues with the new terms, but for any future PRs, I'll include a list of things that might need improvement.
- Subtext length: It should be as short as possible, as the subtext is the text shown below the title of the cards, and its length might affect the UI structure too. Maximum length of the subtext is 2 lines, which is about 10-12 normal length words.
- Resource URLs: most of them are great, but I'd suggest minimizing the use of links from techtarget.com. The website is full of ads, and it's readability is thus low.
And everything else is just right! I love your detailing and the use of correct categories! Keep contributing!
|
Thanks @Buzzpy. I'll take note of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.