Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSON name and latest dependencies #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miguelgargallo
Copy link

This pull request introduces a refined structure for the defaultConfig in our TypeScript configuration, enhancing its readability and maintainability. Changes include the decomposition of the URL and file naming into constituent components, allowing for more flexible customization. Additionally, all project libraries and dependencies have been updated to their latest versions, ensuring compatibility and incorporating the latest features and security improvements.

Key Changes:

  1. Refactored defaultConfig for improved clarity:

    • Introduced variables for protocol, domain, top-level domain (TLD), and URL segments.
    • Concatenated these variables to construct the url and match properties.
    • Dynamically set the outputFileName using the domain name.
  2. Updated all libraries and dependencies to their most recent versions.

Benefits:

  • Increased configurability of the URL structure.
  • Streamlined and more readable codebase.
  • Ensured up-to-date security and feature enhancements with updated dependencies.

Your review and approval of these changes would be greatly appreciated.

let extra = "/c/docs/developers";
// match
let content = "/c/docs";
let rest = "/**";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure this is beneficial - it is quite verbose. I think the way configuration is currently handled is intuitive and easy for individuals to structure in any way they want

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure this is beneficial - it is quite verbose. I think the way configuration is currently handled is intuitive and easy for individuals to structure in any way they want

The idea is that as user I cannot see difference between the two links, this may help me to improve the tool on a great way! <3 Thanks for your time, by the way!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Merry Christmas @steve8708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants