Optional Selector to limit link extraction to be within it #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve8708
reviewed
Dec 22, 2023
| @@ -72,6 +72,8 @@ type Config = { | |||
| url: string; | |||
| /** Pattern to match against for links on a page to subsequently crawl */ | |||
| match: string; | |||
| /** Optional Selector to limit grabbing the links from */ | |||
| matchSelector?: string; | |||
There was a problem hiding this comment.
the term matchSelector is a bit broad, maybe we can call this linkSelector to be more clear whats different between this and selector
There was a problem hiding this comment.
thanks @steve8708 for feedback
my reason for selecting "matchSelector" was to make it tied to the "match" property.
on the other hand, you have a point too.
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize the underlaying Crawlee's feature of limiting link extraction to specific part of the page by exposing it to config file