Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-work integration tests and add test linting #361

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Re-work integration tests and add test linting #361

merged 1 commit into from
Oct 24, 2024

Conversation

devpow112
Copy link
Contributor

@devpow112 devpow112 commented Oct 24, 2024 •
edited
Loading

Bit better structure and actual test linting for the different test types we use.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Report

Generated reports

mocha 
{
  "id": "879ee7bd-e6fe-4364-82ca-b4b4b91e9dbc",
  "version": 2,
  "summary": {
    "github": {
      "organization": "Brightspace",
      "repository": "test-reporting-node",
      "workflow": "ci.yml",
      "runId": 11500461417,
      "runAttempt": 1
    },
    "git": {
      "branch": "depowell/rework",
      "sha": "4524035166aa403d4de7a84f5c4269f4866cacc6"
    },
    "status": "failed",
    "framework": "mocha",
    "operatingSystem": "linux",
    "started": "2024-10-24T13:36:58.790Z",
    "duration": {
      "total": 14164
    },
    "count": {
      "passed": 2,
      "failed": 2,
      "skipped": 2,
      "flaky": 2
    }
  },
  "details": [
    {
      "name": "reporter 1 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-1.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:36:59.048Z",
      "duration": {
        "total": 50,
        "final": 50
      },
      "tool": "Mocha 1 Test Reporting",
      "experience": "Test Framework",
      "type": "ui",
      "retries": 0
    },
    {
      "name": "reporter 1 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-1.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:36:59.602Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Mocha 1 Test Reporting",
      "experience": "Test Framework",
      "type": "ui",
      "retries": 0
    },
    {
      "name": "reporter 1 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-1.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:36:59.603Z",
      "duration": {
        "total": 151,
        "final": 50
      },
      "tool": "Mocha 1 Test Reporting",
      "experience": "Test Framework",
      "type": "ui",
      "retries": 2
    },
    {
      "name": "reporter 1 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-1.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:37:01.260Z",
      "duration": {
        "total": 2,
        "final": 1
      },
      "tool": "Mocha 1 Test Reporting",
      "experience": "Test Framework",
      "type": "ui",
      "retries": 3
    },
    {
      "name": "reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-2.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:37:03.771Z",
      "duration": {
        "total": 50,
        "final": 50
      },
      "tool": "Test Reporting",
      "experience": "Mocha 2 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-2.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:37:04.323Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "Mocha 2 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "reporter 2 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-2.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:37:04.324Z",
      "duration": {
        "total": 151,
        "final": 50
      },
      "tool": "Test Reporting",
      "experience": "Mocha 2 Test Framework",
      "type": "integration",
      "retries": 2
    },
    {
      "name": "reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/mocha/reporter-2.test.js"
      },
      "timeout": 2000,
      "started": "2024-10-24T13:37:05.981Z",
      "duration": {
        "total": 1,
        "final": 1
      },
      "tool": "Test Reporting",
      "experience": "Mocha 2 Test Framework",
      "type": "integration",
      "retries": 3
    }
  ]
}
playwright 
{
  "id": "db324984-b820-4d83-912c-ed052cb9842b",
  "version": 2,
  "summary": {
    "github": {
      "organization": "Brightspace",
      "repository": "test-reporting-node",
      "workflow": "ci.yml",
      "runId": 11500461417,
      "runAttempt": 1
    },
    "git": {
      "branch": "depowell/rework",
      "sha": "4524035166aa403d4de7a84f5c4269f4866cacc6"
    },
    "status": "failed",
    "framework": "playwright",
    "operatingSystem": "linux",
    "started": "2024-10-24T13:37:14.309Z",
    "duration": {
      "total": 45883
    },
    "count": {
      "passed": 5,
      "failed": 5,
      "skipped": 5,
      "flaky": 5
    }
  },
  "details": [
    {
      "name": "[chromium] > reporter 1 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 12,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:15.540Z",
      "duration": {
        "total": 557,
        "final": 557
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[chromium] > reporter 1 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 14,
        "column": 7
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:16.371Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[chromium] > reporter 1 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 17,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:15.548Z",
      "duration": {
        "total": 1670,
        "final": 557
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 2
    },
    {
      "name": "[chromium] > reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 12,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:16.635Z",
      "duration": {
        "total": 555,
        "final": 555
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[chromium] > reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 14,
        "column": 7
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:17.451Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[chromium] > reporter 2 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 17,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:17.708Z",
      "duration": {
        "total": 1668,
        "final": 557
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 2
    },
    {
      "name": "[chromium] > reporter 1 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 27,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:19.697Z",
      "duration": {
        "total": 2027,
        "final": 508
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 3
    },
    {
      "name": "[chromium] > reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 27,
        "column": 2
      },
      "browser": "chromium",
      "timeout": 30000,
      "started": "2024-10-24T13:37:21.913Z",
      "duration": {
        "total": 2026,
        "final": 507
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 3
    },
    {
      "name": "[firefox] > reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 12,
        "column": 2
      },
      "browser": "firefox",
      "timeout": 30000,
      "started": "2024-10-24T13:37:28.107Z",
      "duration": {
        "total": 558,
        "final": 558
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[firefox] > reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 14,
        "column": 7
      },
      "browser": "firefox",
      "timeout": 30000,
      "started": "2024-10-24T13:37:28.935Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[firefox] > reporter 2 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 17,
        "column": 2
      },
      "browser": "firefox",
      "timeout": 30000,
      "started": "2024-10-24T13:37:29.192Z",
      "duration": {
        "total": 1669,
        "final": 557
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 2
    },
    {
      "name": "[firefox] > reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 27,
        "column": 2
      },
      "browser": "firefox",
      "timeout": 30000,
      "started": "2024-10-24T13:37:33.420Z",
      "duration": {
        "total": 2026,
        "final": 508
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 3
    },
    {
      "name": "[webkit] > reporter 1 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 12,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:37.422Z",
      "duration": {
        "total": 558,
        "final": 558
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[webkit] > reporter 1 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 14,
        "column": 7
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:38.253Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[webkit] > reporter 1 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 17,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:38.510Z",
      "duration": {
        "total": 1668,
        "final": 556
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 2
    },
    {
      "name": "[webkit] > reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 12,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:39.600Z",
      "duration": {
        "total": 559,
        "final": 559
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[webkit] > reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 14,
        "column": 7
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:40.429Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 0
    },
    {
      "name": "[webkit] > reporter 2 > flaky",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 17,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:40.687Z",
      "duration": {
        "total": 1667,
        "final": 557
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 2
    },
    {
      "name": "[webkit] > reporter 1 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-1.test.js",
        "line": 27,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:42.631Z",
      "duration": {
        "total": 2027,
        "final": 509
      },
      "tool": "Playwright 1 Test Reporting",
      "experience": "Playwright 1 Test Framework",
      "type": "integration",
      "retries": 3
    },
    {
      "name": "[webkit] > reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/playwright/reporter-2.test.js",
        "line": 27,
        "column": 2
      },
      "browser": "webkit",
      "timeout": 30000,
      "started": "2024-10-24T13:37:44.858Z",
      "duration": {
        "total": 2028,
        "final": 507
      },
      "tool": "Test Reporting",
      "experience": "Playwright 2 Test Framework",
      "type": "visual diff",
      "retries": 3
    }
  ]
}
@web/test-runner 
{
  "id": "85cd863d-b98f-4676-8eaf-bd7b021a245f",
  "version": 2,
  "summary": {
    "github": {
      "organization": "Brightspace",
      "repository": "test-reporting-node",
      "workflow": "ci.yml",
      "runId": 11500461417,
      "runAttempt": 1
    },
    "git": {
      "branch": "depowell/rework",
      "sha": "4524035166aa403d4de7a84f5c4269f4866cacc6"
    },
    "status": "failed",
    "framework": "@web/test-runner",
    "operatingSystem": "linux",
    "started": "2024-10-24T13:38:01.473Z",
    "duration": {
      "total": 17787
    },
    "count": {
      "passed": 4,
      "failed": 4,
      "skipped": 4,
      "flaky": 0
    }
  },
  "details": [
    {
      "name": "reporter 1 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "chrome",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 51,
        "final": 51
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "reporter 1 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "chrome",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "reporter 1 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "chrome",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "chromium",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 51,
        "final": 51
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "chromium",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "chromium",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 1,
        "final": 1
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "firefox",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 51,
        "final": 51
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "firefox",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 1] > reporter 2 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-2.test.js"
      },
      "browser": "firefox",
      "timeout": 120000,
      "started": "2024-10-24T13:38:01.661Z",
      "duration": {
        "total": 1,
        "final": 1
      },
      "tool": "Test Reporting",
      "experience": "WebTestRunner 2 Test Framework",
      "type": "accessibility",
      "retries": 0
    },
    {
      "name": "[group 2] > reporter 1 > passed",
      "status": "passed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "webkit",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 50,
        "final": 50
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[group 2] > reporter 1 > skipped",
      "status": "skipped",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "webkit",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 0,
        "final": 0
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    },
    {
      "name": "[group 2] > reporter 1 > failed",
      "status": "failed",
      "location": {
        "file": "test/integration/data/tests/web-test-runner/reporter-1.test.js"
      },
      "browser": "webkit",
      "timeout": 120000,
      "started": "2024-10-24T13:38:15.671Z",
      "duration": {
        "total": 1,
        "final": 1
      },
      "tool": "WebTestRunner 1 Test Reporting",
      "experience": "WebTestRunner 1 Test Framework",
      "type": "integration",
      "retries": 0
    }
  ]
}

@devpow112 devpow112 marked this pull request as ready for review October 24, 2024 13:38
@devpow112 devpow112 requested a review from a team as a code owner October 24, 2024 13:38
@devpow112 devpow112 enabled auto-merge (squash) October 24, 2024 13:38
@devpow112 devpow112 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 24, 2024
@devpow112 devpow112 merged commit 0fd3dff into main Oct 24, 2024
3 checks passed
@devpow112 devpow112 deleted the depowell/rework branch October 24, 2024 14:00
@d2l-github-release-tokens D2L GitHub Release Tokens
Copy link

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan-DeAraujo Dan-DeAraujo Dan-DeAraujo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devpow112 @Dan-DeAraujo