Correct hostname param default value instructions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my experience `localhost` is often not the default hostname but rather the machine name is. Looking at the code it seems that when an argument isn't provided the value defaults to nodes os.hostname value: https://github.com/Brightspace/frau-local-appresolver/blob/57928f7c0311df33f20ac9a3520114ac3424b82a/lib/appresolver.js#L8 The node docs indicate that `os.hostname` "returns the hostname of the operating system as a string.": https://nodejs.org/api/os.html#os_os_hostname Perhaps this has changed in more recent versions of node but it seems worthwhile to update the docs here to reflect this.
|
Looks like this addresses this issue: #9 |
|
Anyone with permissions to this repo care to merge this? |
|
@CodeBaboon sorry didn't have notifications turned on! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience
localhostis often not the default hostname but rather the machine name is. Looking at the code it seems that when an argument isn't provided the value defaults to nodes os.hostname value:frau-local-appresolver/lib/appresolver.js
Line 8 in 57928f7
The node docs indicate that
os.hostname"returns the hostname of the operating system as a string.": https://nodejs.org/api/os.html#os_os_hostnamePerhaps this has changed in more recent versions of node but it seems worthwhile to update the docs here to reflect this.