Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started draft for bug fix #86

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Started draft for bug fix #86

wants to merge 3 commits into from

Conversation

nilseling
Copy link
Contributor

This is the start of the bug fix to address #85

This needs to be properly tested and adjusted. I already noticed now that when setting a gate that contains 0 cells leads to the clearing of all subsequent gates. This has not been the behaviour before the fix.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (7ba413f) 87.31% compared to head (adaae45) 87.06%.

Files Patch % Lines
R/server-utils.R 9.80% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #86      +/-   ##
==========================================
- Coverage   87.31%   87.06%   -0.25%     
==========================================
  Files          18       18              
  Lines        2751     2761      +10     
==========================================
+ Hits         2402     2404       +2     
- Misses        349      357       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nilseling
Copy link
Contributor Author

I introduced a few more fixes:

  1. when the assay changed, the first gate was not erased (now fixed)
  2. There was a strange bug that when the first marker of a gate was set to empty, the gate was not erased. For safety reasons I have now added that all gates and objects are erased when any marker changes.

@lassedochreden, @SchulzDan please test this in detail when you get the chance. The design choices and expectations are a bit complex to handle alone.

@nilseling
Copy link
Contributor Author

Bzw, the build issues on devel seem to be slang related; see Bioc developers forum slack

@lassedochreden lassedochreden changed the title Satrted draft for bug fix Started draft for bug fix Mar 13, 2024
@SchulzDan
Copy link

Hi, I just installed version 1.15.3 and it seems that empty gates still propagate the previous gate into the downloaded sce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants