Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt comp image tests #84

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Adapt comp image tests #84

merged 2 commits into from
Dec 13, 2023

Conversation

nilseling
Copy link
Contributor

I noticed that I never managed to induce spillover in images in a correct way for the unit tests. This is now more elegant and checks the spillover correction correctly.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e63cbf9) 87.31% compared to head (832e8f1) 87.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel      #84   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files          18       18           
  Lines        2751     2751           
=======================================
  Hits         2402     2402           
  Misses        349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lassedochreden lassedochreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nilseling, this looks good and well tested to me now. Yet R CMD Check is failing right now - Will leave a comment on that in the conversation.

@lassedochreden
Copy link
Collaborator

Hi @nilseling, as you can see R CMD Check is failing due to Cache PhantomJS (Error: Input required and not supplied: path). Furthermore, there are two deprecation warnings from set-output and node12.

Can you comment on that and potentially fix it?

Thanks in advance for clarifying!

@nilseling
Copy link
Contributor Author

So the build issue on devel is due to a bunch of packages not being available at the moment. I'm not fully sure why this is but I think we can ignore this for now.

@lassedochreden lassedochreden merged commit 9b5d688 into devel Dec 13, 2023
3 of 4 checks passed
@lassedochreden lassedochreden deleted the adapt_compImage_tests branch December 13, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants