-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use all available cores in feature extraction #176
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 73.76% 73.29% -0.48%
==========================================
Files 38 39 +1
Lines 2413 2430 +17
==========================================
+ Hits 1780 1781 +1
- Misses 633 649 +16 ☔ View full report in Codecov by Sentry. |
@@ -54,20 +54,7 @@ def test_efel_strictstim(self): | |||
} | |||
) | |||
|
|||
self.assertEqual(self.cell.recordings[0].efeatures["Spikecount"], 0.) | |||
|
|||
def test_efel_threshold(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of another test with the same name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other test has more checks
self.assertEqual(recording.efeatures["Spikecount"], 0.) | ||
self.assertLess(abs(recording.efeatures["AP1_amp"] - 66.68), 0.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code was not getting executed for a long time. The other test was shadowing it
With this change the
Cell
object calls therecording.compute_efeatures
in parallel in theextract_efeatures
function.