Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues in #96 #100

Closed
wants to merge 63 commits into from
Closed

Fixes issues in #96 #100

wants to merge 63 commits into from

Conversation

ABD-AZE
Copy link

@ABD-AZE ABD-AZE commented Nov 1, 2024

Fixing issues in PR#96

@ABD-AZE
Copy link
Author

ABD-AZE commented Nov 1, 2024

@18aaddy you can close PR #96 and continue this PR for the tests. I have resolved the issues you raised in PR #96

@@ -123,7 +137,7 @@ func (e *ExecutionClient) GetAccount(address *seleneCommon.Address, slots []comm
}
account := Account{
Balance: proof.Balance.ToBig(),
Nonce: proof.Nonce,
Nonce: uint64(proof.Nonce),
Code: code,
CodeHash: proof.CodeHash,
StorageHash: proof.StorageHash,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some build error because of access of either null pointer or an invalid memory access, please check that. Mostly coming from GetBlock function

@ABD-AZE ABD-AZE closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants