Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-network): add changi #2143

Merged
merged 34 commits into from
Aug 25, 2023
Merged

Conversation

pierregee
Copy link
Contributor

@pierregee pierregee commented Aug 23, 2023

What this PR does / why we need it:

  • Add changi network
  • Update node to latest to fix regression issues

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit b1371ac
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/64e860f3af93eb0007247f91
😎 Deploy Preview https://deploy-preview-2143--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit dd54dac

  • ghcr.io/birthdayresearch/legacy-api:pr-2143
  • ghcr.io/birthdayresearch/playground-api:pr-2143
  • ghcr.io/birthdayresearch/status-api:pr-2143
  • ghcr.io/birthdayresearch/whale-api:pr-2143

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:dd54dac40147c6814cbe776a3ee9f11024a6c835
  • ghcr.io/birthdayresearch/playground-api:dd54dac40147c6814cbe776a3ee9f11024a6c835
  • ghcr.io/birthdayresearch/status-api:dd54dac40147c6814cbe776a3ee9f11024a6c835
  • ghcr.io/birthdayresearch/whale-api:dd54dac40147c6814cbe776a3ee9f11024a6c835

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2143 (b1371ac) into main (9daa1c1) will decrease coverage by 1.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   93.13%   91.36%   -1.77%     
==========================================
  Files         372      372              
  Lines       11196    11199       +3     
  Branches     1457     1458       +1     
==========================================
- Hits        10427    10232     -195     
- Misses        736      934     +198     
  Partials       33       33              
Files Changed Coverage Δ
apps/legacy-api/src/pipes/NetworkValidationPipe.ts 100.00% <ø> (ø)
apps/whale-api/src/app.configuration.ts 100.00% <ø> (ø)
...pps/whale-api/src/module.api/masternode.service.ts 93.93% <ø> (ø)
packages/ocean-api-client/src/OceanApiClient.ts 56.60% <ø> (ø)
...es/testcontainers/src/containers/DeFiDContainer.ts 91.11% <ø> (ø)
...tcontainers/src/containers/NativeChainContainer.ts 85.71% <ø> (ø)
packages/jellyfish-network/src/Network.ts 89.47% <100.00%> (+1.97%) ⬆️

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pierregee pierregee marked this pull request as ready for review August 25, 2023 06:15
@thedoublejay thedoublejay merged commit adb503f into main Aug 25, 2023
31 of 32 checks passed
@thedoublejay thedoublejay deleted the pierregee/changi-network branch August 25, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants