Quality criteria #188
Merged
Quality criteria #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A1. Modern syntax is preferred.
unknown is preferred over any. any is prohibited.
B5. Content images in <img> have the alt attribute filled.
B9. !important is forbidden.
B10. No global tag styles. Only class selectors or a cascade are used to set styles.
B15. Names of variables, parameters, properties and methods begin with a lowercase letter and are written in camelCase notation.
B19. Boolean variables start with a prefix that can be answered with "yes".
B21. Classes are named with English nouns. The class name starts with a capital letter.
B24. kebab-case is used to name files/folders
B26. The code matches the style of the project.
B30. All class properties and methods are marked with member access (private , public or protected).
B31. The code does not use “magic values”, each of them has a separate variable named as a constant.
B32. The versions of dependencies used are fixed in package.json.
|
@nazar-kotyuha if you have some time, could you please help resolve the conflicts? |
Of course, I will be home soon and will resolve them |
alinaSielina
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.